Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp2518160pxb; Mon, 11 Jan 2021 11:42:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJwjWTHBNoEBtWSMYZViOoGbH4mvmzlfZv0JXkxZAPeDNSerymgsDmj4w9Rf1Mzko1RATmLr X-Received: by 2002:a17:906:f1cc:: with SMTP id gx12mr701257ejb.164.1610394143425; Mon, 11 Jan 2021 11:42:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610394143; cv=none; d=google.com; s=arc-20160816; b=gX/uPrRghDKkIxjri4kKWHzWhv4O7v16r/TBMcut8sxhThAXPnhC7jPc0UpkzVQMgf IRlWc9osZTQtuONbHuz2SUyU/4PemCZYnT0gBKUOc2fj6KFrnRT9ayL9uUnZz9Fg/CMI K+gZe33WObhChDyTTLUHycRMvPWAeduwGzZ5nfdWiLY8OfZbGoWlvbfgA4O+4z6/WiT5 RtONLwbNnVKRfB5rlgdehwbAgJR4XP/EdHFp3wMRZSd5HiumsQDV7vIpRuEukg9xH5Jc WsIJKwUtGNwSAhBwR1NfKxlemtqxMQ2JJZYnJSPpYWq/+9sCdLY8hr8hUU0W5YZw/lNX yFZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=rVxpKz3eMWu56Zjp642GsNTILdyd5r7yRLDT14o3zEA=; b=Zh/sQ8T4IEUsdn/01fb9d3qzd0A3GcEELqKS/VC0tUpseN1358fMz/5yv00pqRgKXU LBkynMcOGM8RgU7aRoTtvpigwFbW/8anQEsiZtFHWy4AKTd09VoI8lgCf4s71jXObWyF C559n8uIDVsIJh1ZbEODkbOt0IVc86qTBBt+SbzoK8zK0M7K4HVDCiEsPbMClbLxWwCK D07mWn26rELTYMZAEs+C9BBozN5IUxX8wjckTTltK4XS0p/evSl9Yl8ivTmbgUgwe1z1 m8UkatpaiUlXcnld3AFuYhxYSjJ69yexqu7bLulSr2mAA3F2G8BbdYGne/iM2uuYo9nx ZIDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pQjOSIJk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d18si133247ejd.342.2021.01.11.11.41.59; Mon, 11 Jan 2021 11:42:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pQjOSIJk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403819AbhAKTlI (ORCPT + 99 others); Mon, 11 Jan 2021 14:41:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:53760 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726211AbhAKTlI (ORCPT ); Mon, 11 Jan 2021 14:41:08 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id EF23522BF3; Mon, 11 Jan 2021 19:40:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610394027; bh=wMhR+nnU1eezFDf6iB1XZoqyfaXAGSf1irT3FkxVVjI=; h=From:To:Cc:Subject:Date:From; b=pQjOSIJk6BNqRFvzbbWQxJWtYYQgM/1Teuad/NVOg/V7SEr6hIyhLTe5klps2lYF6 ACRHW8/YFDzJaPvnqKf3nFr/mgg4aeUALUq/0nBk3KdiqOvqblCJLMT4dMZuJ0KKuw zV73aDaE9w6EOE+U4O8Fv1LqbMtK+M4Ezna7cSE/bVEYHw3Fd9e8IvR187Co19EFFv btoJrImUrD23SSJlPNSx8bMWRjt6b+uw7g+8IEjegpgNSveHHS7Jc96u1i9wzGSI8b deq7HDEZWflnLsMn72f4uJ84+x/n88ZuYMKoe/AmR3qQZG6NCr6DVyt2m50zf1M1bi 8wYlYLaIGrgtQ== From: Mike Rapoport To: Andrew Morton Cc: Andrea Arcangeli , Baoquan He , Borislav Petkov , David Hildenbrand , "H. Peter Anvin" , Ingo Molnar , Mel Gorman , Michal Hocko , Mike Rapoport , Mike Rapoport , Qian Cai , Thomas Gleixner , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Subject: [PATCH v3 0/2] mm: fix initialization of struct page for holes in memory layout Date: Mon, 11 Jan 2021 21:40:15 +0200 Message-Id: <20210111194017.22696-1-rppt@kernel.org> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mike Rapoport Hi, Commit 73a6e474cb37 ("mm: memmap_init: iterate over memblock regions rather that check each PFN") exposed several issues with the memory map initialization and these patches fix those issues. Initially there were crashes during compaction that Qian Cai reported back in April [1]. It seemed back then that the problem was fixed, but a few weeks ago Andrea Arcangeli hit the same bug [2] and there was an additional discussion at [3]. v3: * use architectural zone constraints to set zone links for struct pages corresponding to the holes * drop implicit update of memblock.memory * add a patch that sets pfn 0 to E820_TYPE_RAM on x86 v2: https://lore.kernel.org/lkml/20201209214304.6812-1-rppt@kernel.org/): * added patch that adds all regions in memblock.reserved that do not overlap with memblock.memory to memblock.memory in the beginning of free_area_init() [1] https://lore.kernel.org/lkml/8C537EB7-85EE-4DCF-943E-3CC0ED0DF56D@lca.pw [2] https://lore.kernel.org/lkml/20201121194506.13464-1-aarcange@redhat.com [3] https://lore.kernel.org/mm-commits/20201206005401.qKuAVgOXr%akpm@linux-foundation.org Mike Rapoport (2): x86/setup: don't remove E820_TYPE_RAM for pfn 0 mm: fix initialization of struct page for holes in memory layout arch/x86/kernel/setup.c | 20 +++++----- mm/page_alloc.c | 84 ++++++++++++++++++++++++----------------- 2 files changed, 59 insertions(+), 45 deletions(-) -- 2.28.0