Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <CAD56B7fYivPF33BhXWDPskYqNE5jRxd-sA=6+ushNXhyiCrwiQ@mail.gmail.com>
 <f3b0e354-9390-1ce8-6be5-b6ba9f201589@gmail.com>
In-Reply-To: <f3b0e354-9390-1ce8-6be5-b6ba9f201589@gmail.com>
From:   Paul Thomas <pthomas8589@gmail.com>
Date:   Mon, 11 Jan 2021 17:09:24 -0500
Message-ID: <CAD56B7fJbej4A9QpG4VLfeU-Qu-RwZHEkpJvMab4KhL7Jr-QgA@mail.gmail.com>
Subject: Re: net: macb: can macb use __napi_schedule_irqoff() instead of __napi_schedule()
To:     Heiner Kallweit <hkallweit1@gmail.com>
Cc:     Nicolas Ferre <nicolas.ferre@microchip.com>,
        Claudiu Beznea <claudiu.beznea@microchip.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Russell King <linux@armlinux.org.uk>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        netdev@vger.kernel.org,
        linux-kernel <linux-kernel@vger.kernel.org>,
        linux-riscv@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Jan 11, 2021 at 4:35 PM Heiner Kallweit <hkallweit1@gmail.com> wrote:
>
> On 11.01.2021 20:45, Paul Thomas wrote:
> > Hello, recently I was doing a lot of tracing/profiling to understand
> > an issue we were having. Anyway, during this I ran across
> > __napi_schedule_irqoff() where the comment in dev.c says "Variant of
> > __napi_schedule() assuming hard irqs are masked".
> >
> > It looks like the queue_writel(queue, IDR, bp->rx_intr_mask); call
> > just before the __napi_schedule() call in macb_main.c is doing this
> > hard irq masking? So could it change to be like this?
> >
> It's unsafe under forced irq threading. There has been a number of
> discussions about this topic in the past.
OK thanks, and our use case is forced irq threading under PREEMPT_RT

-Paul

> > --- a/drivers/net/ethernet/cadence/macb_main.c
> > +++ b/drivers/net/ethernet/cadence/macb_main.c
> > @@ -1616,7 +1623,7 @@ static irqreturn_t macb_interrupt(int irq, void *dev_id)
> >
> >                         if (napi_schedule_prep(&queue->napi)) {
> >                                 netdev_vdbg(bp->dev, "scheduling RX softirq\n");
> > -                               __napi_schedule(&queue->napi);
> > +                               __napi_schedule_irqoff(&queue->napi);
> >                         }
> >                 }
> >
> > -Paul
> >
>