Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 11 Jan 2021 16:31:54 -0600
From:   Rob Herring <robh@kernel.org>
To:     Kishon Vijay Abraham I <kishon@ti.com>
Cc:     Bjorn Helgaas <bhelgaas@google.com>,
        Tom Joseph <tjoseph@cadence.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Nadeem Athani <nadeem@cadence.com>, linux-pci@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/4] dt-bindings: PCI: ti,j721e: Add binding to
 represent refclk to the connector
Message-ID: <20210111223154.GA3175106@robh.at.kernel.org>
References: <20210104124103.30930-1-kishon@ti.com>
 <20210104124103.30930-2-kishon@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210104124103.30930-2-kishon@ti.com>
Precedence: bulk

On Mon, Jan 04, 2021 at 06:11:00PM +0530, Kishon Vijay Abraham I wrote:
> Add binding to represent refclk to the PCIe connector.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
>  .../bindings/pci/ti,j721e-pci-host.yaml         | 17 +++++++++++++----
>  1 file changed, 13 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> index 0880a613ece6..7607018a115b 100644
> --- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> +++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> @@ -46,12 +46,21 @@ properties:
>      maxItems: 1
>  
>    clocks:
> -    maxItems: 1
> -    description: clock-specifier to represent input to the PCIe
> +    minItems: 1
> +    maxItems: 2
> +    description: clock-specifier to represent input to the PCIe for 1 item.
> +      2nd item if present represents reference clock to the connector.
>  
>    clock-names:
> -    items:
> -      - const: fck
> +    oneOf:
> +      - description: Represent input clock to the PCIe
> +        items:
> +          - const: fck
> +      - description: Represent input clock to the PCIe and reference clock to
> +          the connector.
> +        items:
> +          - const: fck
> +          - const: pcie_refclk

Can be just:

minItems: 1
items:
  - const: fck
  - const: pcie_refclk