Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp2816984pxb; Mon, 11 Jan 2021 22:07:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJxInUj+D1T+AbwXC4PlaiQdjJuY2Mg8Zd8FzJt66uerAnprK21ExJ6n4+Fz6tHbEGW+mgso X-Received: by 2002:a05:6402:1caa:: with SMTP id cz10mr2096956edb.345.1610431655536; Mon, 11 Jan 2021 22:07:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610431655; cv=none; d=google.com; s=arc-20160816; b=QTyiY8pomuVbaiPVjlJJOmxXEq/8O8hX3YGBCj5CTn0aKynHZlpel4pzv9d92gz8Fh AS6U9IBmqWEZ/3Z4XbE90w8nC/Ad2MCi9a8OdkUJcf+YSROKhNSik/Il7tlUSDcH/4zi XUWC5BXh5VpsH9fdG+aXeE4gUtRxbS2NiFOhq95RpFjdON9/NJUZK8WS1PrDo9z/h6ZX JCnjfBY/SZc83Il3v73LgengBoB9deqErjtrd0SqAQT5zKbOSRS8wqYb4EA7rS8WwXLs FlatjBYNN2ZwGSx/ICjQume3a8L2hqJ8ryRd3Tmxfzytbe5MfKGrdAz/GHpauaonCQnH IMZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=CZPvS2q5csH7PBm+K6uTxjC01zmRa0ahWkqZ5xhS24U=; b=QSzz7KsxYtcRdeQTb20Jzhu4cqbSv+7cUwIgFSc/VDfvhNsoCsTy/2dw+UCLzyVRsD sx6SSJJ0XKc65AH3hoJLpOVeHO+GdqVHpqOjodQ0yADaNAEvkIlk6/jRnuhV7vHnH/jT UXVaKd3W4uKnuOnR2iWguIyYH5Ctpxn3sEZZSZ6d69T4GlSBRz/no6/WTJEFRLl3QpiD ObJppbOaMGntLgjx1a6iUICycQ+MUMgOnK9FiuumxZ4pwabpil8EiOrNCGFKEG3LXY01 atHYoBXK+m5Ls4DevGed3Bcn+CNfBOuAxJpiTXG8H2YLtbIh6fvLtdaujI8KWz9JYuJ3 M1MA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=e6GZCkVT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m13si989991edi.155.2021.01.11.22.07.11; Mon, 11 Jan 2021 22:07:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=e6GZCkVT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733296AbhAKNpk (ORCPT + 99 others); Mon, 11 Jan 2021 08:45:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:58610 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731406AbhAKNLa (ORCPT ); Mon, 11 Jan 2021 08:11:30 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id E1BB62253A; Mon, 11 Jan 2021 13:10:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1610370649; bh=9LQ54fnhvOE76S0JLfOU0aM96N2ZyaGgbNMalhH2Hx4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=e6GZCkVTe2cgFVKoWsbyxEeZmeS98MwCCn/R42XDio3f0PitIDz1UDe+bT3838kzF 8WIqCQHRC09dEvT+haL8O0zI9pedgvoWnfMKXxKs80Vf6G+do/r1C8ntBAmO3MqZ7X J7Gl3/KLDRo8IN6IEXGAHwicFPyPd7B/+XJC4g0g= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Heiner Kallweit , Jakub Kicinski Subject: [PATCH 5.4 38/92] r8169: work around power-saving bug on some chip versions Date: Mon, 11 Jan 2021 14:01:42 +0100 Message-Id: <20210111130040.986000050@linuxfoundation.org> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210111130039.165470698@linuxfoundation.org> References: <20210111130039.165470698@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Heiner Kallweit [ Upstream commit e80bd76fbf563cc7ed8c9e9f3bbcdf59b0897f69 ] A user reported failing network with RTL8168dp (a quite rare chip version). Realtek confirmed that few chip versions suffer from a PLL power-down hw bug. Fixes: 07df5bd874f0 ("r8169: power down chip in probe") Signed-off-by: Heiner Kallweit Link: https://lore.kernel.org/r/a1c39460-d533-7f9e-fa9d-2b8990b02426@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/realtek/r8169_main.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -3958,7 +3958,8 @@ static void rtl_pll_power_down(struct rt } switch (tp->mac_version) { - case RTL_GIGA_MAC_VER_25 ... RTL_GIGA_MAC_VER_33: + case RTL_GIGA_MAC_VER_25 ... RTL_GIGA_MAC_VER_26: + case RTL_GIGA_MAC_VER_32 ... RTL_GIGA_MAC_VER_33: case RTL_GIGA_MAC_VER_37: case RTL_GIGA_MAC_VER_39: case RTL_GIGA_MAC_VER_43: @@ -3987,7 +3988,8 @@ static void rtl_pll_power_down(struct rt static void rtl_pll_power_up(struct rtl8169_private *tp) { switch (tp->mac_version) { - case RTL_GIGA_MAC_VER_25 ... RTL_GIGA_MAC_VER_33: + case RTL_GIGA_MAC_VER_25 ... RTL_GIGA_MAC_VER_26: + case RTL_GIGA_MAC_VER_32 ... RTL_GIGA_MAC_VER_33: case RTL_GIGA_MAC_VER_37: case RTL_GIGA_MAC_VER_39: case RTL_GIGA_MAC_VER_43: