Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1610092095-5113-1-git-send-email-henryc.chen@mediatek.com>
 <1610092095-5113-2-git-send-email-henryc.chen@mediatek.com>
 <1610163019.789930.3762037.nullmailer@robh.at.kernel.org> <1610333553.2992.7.camel@mtksdaap41>
In-Reply-To: <1610333553.2992.7.camel@mtksdaap41>
From:   Rob Herring <robh@kernel.org>
Date:   Mon, 11 Jan 2021 09:42:54 -0600
Message-ID: <CAL_Jsq+W3UL4-s6ezFJrhUYko2EBPsO9nMOGzGR1nQT3x_VtdQ@mail.gmail.com>
Subject: Re: [PATCH V7 01/13] dt-bindings: soc: Add dvfsrc driver bindings
To:     Henry Chen <henryc.chen@mediatek.com>
Cc:     "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Fan Chen <fan.chen@mediatek.com>,
        "open list:THERMAL" <linux-pm@vger.kernel.org>,
        James Liao <jamesjj.liao@mediatek.com>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Georgi Djakov <georgi.djakov@linaro.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Ryan Case <ryandcase@chromium.org>,
        Arvin Wang <arvin.wang@mediatek.com>,
        Nicolas Boichat <drinkcat@google.com>,
        Stephen Boyd <swboyd@chromium.org>,
        Mark Brown <broonie@kernel.org>, devicetree@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Jan 10, 2021 at 8:52 PM Henry Chen <henryc.chen@mediatek.com> wrote:
>
> Hi Rob,
>
> On Fri, 2021-01-08 at 20:30 -0700, Rob Herring wrote:
> > On Fri, 08 Jan 2021 15:48:03 +0800, Henry Chen wrote:
> > > Document the binding for enabling dvfsrc on MediaTek SoC.
> > >
> > > Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
> > > ---
> > >  .../devicetree/bindings/soc/mediatek/dvfsrc.yaml   | 67 ++++++++++++++++++++++
> > >  1 file changed, 67 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/soc/mediatek/dvfsrc.yaml
> > >
> >
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > Documentation/devicetree/bindings/soc/mediatek/dvfsrc.example.dts:19:18: fatal error: dt-bindings/interconnect/mtk,mt8183-emi.h: No such file or directory
> >    19 |         #include <dt-bindings/interconnect/mtk,mt8183-emi.h>
> >       |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> Sorry, because this header file is added on "[V7,07/13] dt-bindings:
> interconnect: add MT8183 interconnect dt-bindings".
> Should I change the order of the patchset (let the yaml pathc behind the
> header) to fixed that ?

DT headers should be part of the binding schema patch. (Or at least come first).

Rob