Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp2890634pxb; Tue, 12 Jan 2021 00:44:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJyV/DDvq3lok5k02RKSDuXpZ6GbX+D7DllThP1WT2TAFN6nT3HmXNnuJqs1buFosBkhwPwM X-Received: by 2002:a17:906:bcd5:: with SMTP id lw21mr479141ejb.408.1610441040976; Tue, 12 Jan 2021 00:44:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610441040; cv=none; d=google.com; s=arc-20160816; b=qfJ14qL53vFeVDXPrbtZ3VMngoA6vvXWaDo8zkZERcX+qZE/7K9KIVYUDlnOYD2yWk EN1P32ThtYSKtbL09EWPZB0GQkDYSbdIcKwNMo+Ss2OhF7btaQ1neBJE2qp8FPxdlS2j /T9tuENt1baTPveNos+sfmuknlkGL6KiQYvVsfKNA2w95uX2rFx2Rcc8fN9jrkEmLQxf gLb9ViZ04TK3ltsXg/6ApFnHYVOmOXfkQwdDPo0+AeYiywaY6DD2g395S6K0aH5E6vbS pWUZLYLuwBwEyfQGEWVrdrLZmYfT2fuikWj0v9zSJ5Xv1TufR4BV69W+OFvsUvH+fGI+ sQ1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=in6xsSHxV8O3fQBWvLzeKBxPHjiCQsY30uQmoLBjygo=; b=VTMFziKvacs9WzFYPviTi0yEybQxb+kL+pgNPH6tr0j4iMQ+LzmdS8rjw/yiwjIkxi a2Lwiwj0FjO0lJ65Ca97NYfRmqbiTn2pOkUxEhvg4jfL81RwlTXTR3HkZgSh8QHS7twj w+psL2Xk+xTy40ZmlE9c0ZluwJUmTYnWwEgS+EDaNkwgx5KXoO1e8qR/0jpvijJPt6yY 05SVY4zkJszWx1L6+dvH1g/Y97rPIumPo2yzTS3TGJhDitmsYUiulbCrXAatCirInst3 gZ89yjcXbdihyxiom9yrvskiKmUtX9XrUg7UMCsX1p+6+Csw0lIDTeX3XdOizNtpN+AE +JNQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z4si847186ejw.380.2021.01.12.00.43.38; Tue, 12 Jan 2021 00:44:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388368AbhAKQHQ (ORCPT + 99 others); Mon, 11 Jan 2021 11:07:16 -0500 Received: from verein.lst.de ([213.95.11.211]:51776 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731709AbhAKQHQ (ORCPT ); Mon, 11 Jan 2021 11:07:16 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 4D9A667373; Mon, 11 Jan 2021 17:06:33 +0100 (CET) Date: Mon, 11 Jan 2021 17:06:33 +0100 From: Christoph Hellwig To: Hannes Reinecke Cc: Daniel Wagner , Enzo Matsumiya , Sagi Grimberg , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Jens Axboe , Keith Busch , Christoph Hellwig Subject: Re: [PATCH] nvme: hwmon: fix crash on device teardown Message-ID: <20210111160633.GA27554@lst.de> References: <20201209213228.5044-1-ematsumiya@suse.de> <4ebb1b8c-4bb0-6ebf-3417-d4aee1bdd3a8@suse.de> <20201230143805.2v4izgkzbnisssvr@beryllium.lan> <20201230151653.ozlqlwef7f2tarwz@beryllium.lan> <20201230153138.4f2jd2yd2vkqndby@beryllium.lan> <20210104210610.hliiupywksawgei3@hyori> <20210105094545.3tq7c6ev5yn3bhyi@beryllium.lan> <412d45ef-40af-24c3-4aa2-042ecbba05cd@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <412d45ef-40af-24c3-4aa2-042ecbba05cd@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We could just stop using devm and do explicit resource management. Btw, for the next patch please cc the author of the nvme-hwmon code.