Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: fpE9PYAcfWlhKyljkrAHLe9X+Sb7+axLGKLb96CGT2qn7rJxxkPs74BLrHmRDDLHFytpEP7GHv
 vP6rNsQU32lQ==
IronPort-SDR: okmijB6pK3Lhm52pmv0ELX5gRiRSZd8ahVZvHV+DGR1zNO9zoLalHFWpdKIHNqG59+5rYf242o
 m/h8Xs3084kA==
Subject: Re: [PATCH 0/2] perf/x86/intel/uncore: Derive die id from NUMA info
 with more than 8 nodes
To:     Steve Wahl <steve.wahl@hpe.com>, rja_direct@groups.int.hpe.com,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Borislav Petkov <bp@alien8.de>, x86@kernel.org,
        "H. Peter Anvin" <hpa@zytor.com>, linux-kernel@vger.kernel.org
Cc:     "Liang, Kan" <kan.liang@intel.com>
References: <20210108153549.108989-1-steve.wahl@hpe.com>
From:   "Liang, Kan" <kan.liang@linux.intel.com>
Message-ID: <fa012ba7-714a-00bc-257c-62f7ddcde7fc@linux.intel.com>
Date:   Mon, 11 Jan 2021 11:39:21 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <20210108153549.108989-1-steve.wahl@hpe.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 1/8/2021 10:35 AM, Steve Wahl wrote:
> For Intel uncore, the registers being used to identify the die don't
> contain enough bits to uniquely identify more than 8 dies.  On
> systems with more than 8 dies, this results in error messages of the
> form "skx_uncore: probe of XXXX:XX:XX.X failed with error -22", and
> some perf counters showing up as "<not supported>".
> 
> On such systems, use NUMA information to determine die id.
> 
> Continue to use the register information with 8 or fewer numa nodes to
> cover cases like NUMA not being enabled.
> 
> The first patch moves translation from physical to logical die id
> earlier in the code, and stores only the logical id.  The logical id
> is the only one that is really used.  Without this change the second
> patch would have to store both physical and logical id, which was much
> more complicated.
> 
> The second patch adds the alternative of deriving the logical die id
> from the NUMA information when there are more than 8 nodes.
> 
> Steve Wahl (2):
>    perf/x86/intel/uncore: Store the logical die id instead of the
>      physical die id.
>    perf/x86/intel/uncore: With > 8 nodes, get pci bus die id from NUMA
>      info
> 
>   arch/x86/events/intel/uncore.c       |  58 +++++---------
>   arch/x86/events/intel/uncore.h       |   5 +-
>   arch/x86/events/intel/uncore_snb.c   |   2 +-
>   arch/x86/events/intel/uncore_snbep.c | 114 ++++++++++++++++++---------
>   4 files changed, 99 insertions(+), 80 deletions(-)
> 

Thanks Steve for working on the issue. The patch set looks good to me.

Reviewed-by: Kan Liang <kan.liang@linux.intel.com>

Thanks,
Kan