Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp2933765pxb; Tue, 12 Jan 2021 02:08:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJw0W3gGjtNXUujp4cXQs444PArRibjpKsXoyZ0xWK8aJRYV78JxVvgyUAzPzVFelBiSNNWd X-Received: by 2002:a17:906:3711:: with SMTP id d17mr2586607ejc.121.1610446121443; Tue, 12 Jan 2021 02:08:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610446121; cv=none; d=google.com; s=arc-20160816; b=Ps4dT6g3g0HD3b95k/kjdS1f9DK42cLgEFC65pqP4c5Skwdho49W/4qZizqUIqmHi9 HS95QSxDFTd7HlKVmfe0gnNZSSyvzTeEm5NMIF/0S3j05efXu1vVUMwOcYjuOWkpOLTr kjOEvKow/COpvrUPQ3RfoXkUNFjrVdaccuk7hzbHVnb5E358C4EkTdCXnro2fteNK/QY o8ySjnYztR07Ibll/WytSNswhF1DuCmEAvoQQcd0qCH/EMgJCEpIwILO0QPd1onXWGyP XNSYUAi+A32b5W0XVUXlV0r76GhY3NpAO0WsNhEG5R8ljywAiBXoxHGa7oKuxSdok9GU fV7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=MatKQSm+/WVgTUvqaobQ9dQnxxqAjemkbsMSuNsvDMg=; b=WOTy/Wny3sLS2dGajR77Mvm6zjQrcT14zVMyg6v2UYxD2VGKqiDTDOOhCMWX/gKLIY M3kBFcz6gB4fKSQ3OO74Hb9h/i8ha95dDZOCtwWcq/KxPCQ9oGR5pj7hkKcrdbXviLQM 18Snbjj2IFNvha05gCoVm1dvd0vvuzyi1b98kZDPToRU+gRVbvskgEPx00XVSElEUFiY sJKaFbQdT/vE8/BQOlLmrh0Fm40jL2FDYkULwKDlWPKh5RRFwtuI529Dk0YwggrV5L5n nje/joSWri/dNO88671dBTlKNr0SsLQhGQJ5X1RUyBZ31GpYuYXYZIp3O0XVbVxi5mb1 /8qw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=pHPNCZg3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f8si144967ejf.3.2021.01.12.02.08.17; Tue, 12 Jan 2021 02:08:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=pHPNCZg3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404415AbhALAYv (ORCPT + 99 others); Mon, 11 Jan 2021 19:24:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403837AbhAKXLy (ORCPT ); Mon, 11 Jan 2021 18:11:54 -0500 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34128C06179F; Mon, 11 Jan 2021 15:11:14 -0800 (PST) Received: by mail-ed1-x536.google.com with SMTP id g24so233999edw.9; Mon, 11 Jan 2021 15:11:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=MatKQSm+/WVgTUvqaobQ9dQnxxqAjemkbsMSuNsvDMg=; b=pHPNCZg38qIe/4vlk8/Un6gLukJz5+6c66WTixLp6AFkm3a6TAmvuS3M7dgpMJB7mz N0PwklTjnEku56YNfkYWD0JB++NoNa8xFciif71vvEH+IvQsIanTprDDwH2sxlaFIFnx pkS3/pXkXQy7FGWGTtGWL100zDQKtKkPKkGPaE0oUkBpz4E4fKhK0UHvXH7M0aq0j3qZ QFmv2w4ja3EKc+2NJYL6QE2+e3F17zTJOwoHv8RWGENYvqRN5u8yieIuU+0NqqPx/NvK xRqfhAP378dr79Tr138Uw3XEqSv0KHyPjq9TPtlBgPGDHv5fGZKzpY037H1soxzsyOM2 9WAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=MatKQSm+/WVgTUvqaobQ9dQnxxqAjemkbsMSuNsvDMg=; b=UCl1/IF4szM9G4MjKvUVotl1gLibTKfq0H8YZgKbJnYvYRI/pnG2+YekK2Rimy5HDO wM/B/my5kq78VZbhHNmTFkXGn7EdfegWcJMPZwzbsA4zvacYUezSEJDSuFxEI0XFk5OC VVXn3kPemlfRKua3Dcfu2jUXghXf1a8tir7wnba9ujfLIAH4ipd+ywI9h8s2WQpgjoDv S8QnLVLMiq5UqvT0Y0xxx4WVwm4cxcoim2d+aT4WL6rhKeQ5+ohqaBH20y7k7RTRJ3MR zTBsu+fEnmVFK81lAWN57WY5/AJGzeQYooKahA5XSp9UvcWObwUUynb7h9C9Zoe+TAhq keTw== X-Gm-Message-State: AOAM533lDJP/JektxiC5clx6ClCYXJi1KB+XD96UpRwtP/8z1riUXICP fa2/h6R3xyPrf7KLGqjYNNw= X-Received: by 2002:aa7:d459:: with SMTP id q25mr1145671edr.279.1610406672989; Mon, 11 Jan 2021 15:11:12 -0800 (PST) Received: from localhost.localdomain (ip5f5bfcff.dynamic.kabel-deutschland.de. [95.91.252.255]) by smtp.gmail.com with ESMTPSA id ch30sm598175edb.8.2021.01.11.15.11.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 15:11:12 -0800 (PST) From: Bean Huo To: alim.akhtar@samsung.com, avri.altman@wdc.com, john.garry@huawei.com, jejb@linux.ibm.com, martin.petersen@oracle.com, ebiggers@google.com, satyat@google.com, shipujin.t@gmail.com Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Bean Huo Subject: [PATCH v2 2/2] scsi: ufs: Remove unnecessary devm_kfree Date: Tue, 12 Jan 2021 00:10:58 +0100 Message-Id: <20210111231058.14559-3-huobean@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210111231058.14559-1-huobean@gmail.com> References: <20210111231058.14559-1-huobean@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bean Huo The memory allocated with devm_kzalloc() is freed automatically no need to explicitly call devm_kfree. Reviewed-by: Eric Biggers Signed-off-by: Bean Huo --- drivers/scsi/ufs/ufshcd-crypto.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd-crypto.c b/drivers/scsi/ufs/ufshcd-crypto.c index 07310b12a5dc..ec80ec83cf85 100644 --- a/drivers/scsi/ufs/ufshcd-crypto.c +++ b/drivers/scsi/ufs/ufshcd-crypto.c @@ -182,7 +182,7 @@ int ufshcd_hba_init_crypto_capabilities(struct ufs_hba *hba) err = blk_ksm_init(&hba->ksm, hba->crypto_capabilities.config_count + 1); if (err) - goto out_free_caps; + goto out; hba->ksm.ksm_ll_ops = ufshcd_ksm_ops; /* UFS only supports 8 bytes for any DUN */ @@ -208,8 +208,6 @@ int ufshcd_hba_init_crypto_capabilities(struct ufs_hba *hba) return 0; -out_free_caps: - devm_kfree(hba->dev, hba->crypto_cap_array); out: /* Indicate that init failed by clearing UFSHCD_CAP_CRYPTO */ hba->caps &= ~UFSHCD_CAP_CRYPTO; -- 2.17.1