Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 11 Jan 2021 15:16:50 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Praveen Chaudhary <praveen5582@gmail.com>
Cc:     davem@davemloft.net, corbet@lwn.net, kuznet@ms2.inr.ac.ru,
        yoshfuji@linux-ipv6.org, netdev@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        Zhenggen Xu <zxu@linkedin.com>
Subject: Re: [PATCH v0 net-next 1/1] Allow user to set metric on default
 route learned via Router Advertisement.
Message-ID: <20210111151650.41ac7532@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20210111215829.3774-2-pchaudhary@linkedin.com>
References: <20210111215829.3774-1-pchaudhary@linkedin.com>
        <20210111215829.3774-2-pchaudhary@linkedin.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 11 Jan 2021 13:58:29 -0800 Praveen Chaudhary wrote:
> For IPv4, default route is learned via DHCPv4 and user is allowed to change
> metric using config etc/network/interfaces. But for IPv6, default route can
> be learned via RA, for which, currently a fixed metric value 1024 is used.
> 
> Ideally, user should be able to configure metric on default route for IPv6
> similar to IPv4. This fix adds sysctl for the same.
> 
> Signed-off-by: Praveen Chaudhary<pchaudhary@linkedin.com>
> Signed-off-by: Zhenggen Xu<zxu@linkedin.com>

Please put a space between the name and '<'.

I haven't looked at the code yet, but I can tell you this patch
triggers a few checkpatch --strict warnings, and breaks allmodconfig
build.