Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp2942867pxb; Tue, 12 Jan 2021 02:25:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJyeU7l8zlbpbGV3fXqjssYUlVHLsnwe3r8I1gUKpgrVxssNd885yECrPaF9teYXv+IGH9Ev X-Received: by 2002:aa7:d784:: with SMTP id s4mr2777882edq.215.1610447127845; Tue, 12 Jan 2021 02:25:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610447127; cv=none; d=google.com; s=arc-20160816; b=0m/99iojr0kVtwwV6iyfvY/cj4DMrEQVtXE6wO1j+jUzLhrkxkwlE9kqIXML8tt5wl jJKe5ygZVQUM24faRdDrbaygzGFt9+MALnl2BW0thzJeP8oQsIeb9R2wtrlTGwZNMfLb nmCAvlNSlNkH+kIAkYF51HWbwZ9E7cnG+UZnQm8PIFDqwefKQcfCzCF7NctD8IImgLK5 NxK+oTDbuuoPTyy8U1u8PEmyKncIF7riRPzfual7h5gDoRfvQ3h/VnRTJjN6mwtQxwr4 avuCtSzE0cMR45TxMfE5KM2nFUiuWneVBhHDAMHxmI5SxjAuRqApstMCYffkCIUBoJHl EyTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=XS9x4tfe1NBdhR5zesiN+CGaWhvZlzcF27NwBDw1wRc=; b=QVQEvKWfDVD8ilSzK7mzXS0832lP2w3njEfTfI9QRiFJRnsnq0Zdwa5PT1JUVaul1k rPtXlEQ8PAPTWP6VBj7ajxjcccMZY9uhLXGOwmJmbzEFhs4GKFLaFfGzlsDeBqomBqbV 975mC1JgipI/nLSx34lr8dwc39/281JF5FHqYFbrRcO5PCMbjUKoeAKyuV55rv9RMi5+ 9OCLtm1QFLXoW17d+1WsgvzAap9qt45HgjZkUDsSq1TP/zPRMNsa0GXaLdMVamjX31RG iJf+R8ysYn9r+sdvnH7FWOeJRZTBTc7BW4tAcqLu4Pw/ozv2NCInoqFgTUgI+JaOFFRl Yu7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=BwuL7yZD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c20si1056757edw.222.2021.01.12.02.25.04; Tue, 12 Jan 2021 02:25:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=BwuL7yZD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405162AbhALAZP (ORCPT + 99 others); Mon, 11 Jan 2021 19:25:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404230AbhALAFQ (ORCPT ); Mon, 11 Jan 2021 19:05:16 -0500 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23EC2C061794 for ; Mon, 11 Jan 2021 16:04:36 -0800 (PST) Received: by mail-lf1-x134.google.com with SMTP id o13so670048lfr.3 for ; Mon, 11 Jan 2021 16:04:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XS9x4tfe1NBdhR5zesiN+CGaWhvZlzcF27NwBDw1wRc=; b=BwuL7yZDyqnpbChB/UKU5UXidDWpM3L+UCh8vme2kp6gTLToZsZm1L1RfZcYNQGazl DFFfgj4uolkUm4miyvKJI6qqjg6Z/Ki+44uqk4vu4c5RPyuUiNAvdVru3mNlE8qEz6PM TaWeQMdrvQH6MprIAZ7kh3zKiLuSUNKE32ZBoUFtJQljg/EtDbgtGsdmEJUAY0L3Fnvv JEfjbD2zpD8dscnUTTaBP2NWfr398kEhY98XyiLXGdb74Q+Nab1+nFXUJqe4j/RNxyUM E3tR6xYDgRI4TTtAwI+h1FH2FT97l6Zggb1QX8Csql6ftmNXBO+Xs8tSuIsSOmwo2tVT cmOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XS9x4tfe1NBdhR5zesiN+CGaWhvZlzcF27NwBDw1wRc=; b=ICAShJ7d1/aj6hy/C2ql6PUrB+qpxC1iBzvi8WpCPA+4uGMlHYQQNvBmRNQMGzr9ut h+WaVI61nmxh67TxYoqlIByKtHl0uzI+OHGIXYjV5v+1bOS/Vle+pNYMMty4Cu8OtpPX zMMgPY+WBUzyaOCNawV7zMXZfS8pgEYeanxlLlDR4pJ//LXD+uxENHRicoXKWieWJMfP C/bcvJzteZbOyeLryVacqCGT4d9dBHKHG/z5cUE0SQv/xr6wRGvFzJZnMQYtZEDCtk0A INmbT4ywXsZFgmEcY0yUBKVRkQ5FXhQU9DU/t2h8ubOie8fK+jPj/Aj0iJhKuEfnNK4o W76w== X-Gm-Message-State: AOAM530nM/aCZhFS85ALAYE3Z83XG7MQw0Hly2av9v2UfqckwlDfZr0B N6Z8hWjuk0rU/+VoznfZodcBdSGBY4Cj3nJLPg6qJw== X-Received: by 2002:a19:716:: with SMTP id 22mr890888lfh.390.1610409874106; Mon, 11 Jan 2021 16:04:34 -0800 (PST) MIME-Version: 1.0 References: <20200916041908.66649-1-ebiggers@kernel.org> <20201007035021.GB912@sol.localdomain> <20201026163343.GA858@sol.localdomain> In-Reply-To: From: Jann Horn Date: Tue, 12 Jan 2021 01:04:07 +0100 Message-ID: Subject: Re: [PATCH] random: fix the RNDRESEEDCRNG ioctl To: Eric Biggers Cc: "Theodore Ts'o" , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , kernel list , Andy Lutomirski Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 4, 2021 at 7:55 PM Eric Biggers wrote: > On Fri, Nov 20, 2020 at 10:52:14AM -0800, Eric Biggers wrote: > > On Mon, Oct 26, 2020 at 09:33:43AM -0700, Eric Biggers wrote: > > > On Tue, Oct 06, 2020 at 08:50:21PM -0700, Eric Biggers wrote: > > > > On Tue, Sep 15, 2020 at 09:19:08PM -0700, Eric Biggers wrote: > > > > > From: Eric Biggers > > > > > > > > > > The RNDRESEEDCRNG ioctl reseeds the primary_crng from itself, which > > > > > doesn't make sense. Reseed it from the input_pool instead. > > > > > > > > > > Fixes: d848e5f8e1eb ("random: add new ioctl RNDRESEEDCRNG") > > > > > Cc: stable@vger.kernel.org > > > > > Signed-off-by: Eric Biggers > > > > > > > > Ping? > > > > > > Ping. > > > > Ping. > > Ping. You may want to resend to akpm with a note that the maintainer is unresponsive.