Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp2953340pxb; Tue, 12 Jan 2021 02:44:13 -0800 (PST) X-Google-Smtp-Source: ABdhPJyuwffmov+VqGiac28jpqF1udBmYXSf9nwzKgTS+Lw6OiZMHSBH6EbTvskdcmukO9XJLg3k X-Received: by 2002:a17:906:b309:: with SMTP id n9mr2735597ejz.365.1610448253010; Tue, 12 Jan 2021 02:44:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610448253; cv=none; d=google.com; s=arc-20160816; b=qy1TGO0d5MxqmqwN+HQ8nmN60xt71q4h4Jee01O8eRo6Rt5aZqkjN3HEevXWeRLwpg 0D9DxBuQPucHAskXW1LiJMVVHZfsSF1egbSmz+8riMsyCIg38l3c+8fZ/mOua7+70iCp KSQBhvpse4u85d54Z+ikND2jfnzhbpuHIJeEQhFMeNB7rWCAvvLb/XxHtGwNuoTL1KIO Kd8V+0pk8OgvOKhg85zmV7yPt1wypsbm2d03+T3OZDQQ1ATSFeuViE0qWfbG1ZyHTuUN 3t9DExNBqot7GrRiXx6DMoyUu5LtVFWSkay85nA9H6cmTD+KJwRNwcx51JM7Z0ZGoXxK dY+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=U0QFX5rZ8cZeYzNTcpgiWoFbTGo7cy/3jJ/6tSklof0=; b=XjvZKXQ/vaT2P6fpg2dFq4nTqoJ5Vda/jG6ytDb6fz4a2pl6NwwqfmNqUYTKZl1jNn ZxhAwpGqYB3cON2EkzhU6uLtYm+UKR6cyDLKuT04J3OxevhjChzjqUa4YhxNhp8NgSxy slSQ/118ZaCfV4CNLSeEqLiGBMI69gESIfzAhsD6Mymr/PAqwYjs+pWtFmLUHym4MbrN +2WFpP3C3zxzX7SpRt2K1y4o8Jd2F2Uszs6jnLl1qpZKLstyDv8uu0ZN9AmwYgTyAjV2 ItAo9ekye/nQhhFohlruIAo4igOLO4bM3t3nSHkXh1IjLwssAgKgeynUve/kFCUuHM2C Io9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=A6izqXLA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ca24si1057707edb.492.2021.01.12.02.43.49; Tue, 12 Jan 2021 02:44:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=A6izqXLA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729972AbhALA6o (ORCPT + 99 others); Mon, 11 Jan 2021 19:58:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:50510 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729918AbhALA6n (ORCPT ); Mon, 11 Jan 2021 19:58:43 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 45BBE2253A; Tue, 12 Jan 2021 00:58:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1610413082; bh=0IbP6+yAHA6WBKI+PXFr6t+4Edq3ezr16QrKJO3wgBw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=A6izqXLA99i7sd9NLwPIoH0d8c/1eFPcKbFJ/gcfNZTLoI0KKY0DOOXiY0oC3Sld5 ukFNIcoiA7YwQmGao5t3i7O84n61o5VLD2HyjC4J6/vdwLYCm6Hs6fo7nXM9vDDUun H4Uwqm6huCO88se2fwlFjLGFjxbgO1FTiS8D7IHw= Date: Mon, 11 Jan 2021 16:58:01 -0800 From: Andrew Morton To: Mike Rapoport Cc: Andrea Arcangeli , Baoquan He , Borislav Petkov , David Hildenbrand , "H. Peter Anvin" , Ingo Molnar , Mel Gorman , Michal Hocko , Mike Rapoport , Qian Cai , Thomas Gleixner , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Subject: Re: [PATCH v3 0/2] mm: fix initialization of struct page for holes in memory layout Message-Id: <20210111165801.ef35b01b15132d5513b2f3ce@linux-foundation.org> In-Reply-To: <20210111194017.22696-1-rppt@kernel.org> References: <20210111194017.22696-1-rppt@kernel.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 11 Jan 2021 21:40:15 +0200 Mike Rapoport wrote: > Commit 73a6e474cb37 ("mm: memmap_init: iterate over > memblock regions rather that check each PFN") exposed several issues with > the memory map initialization and these patches fix those issues. > > Initially there were crashes during compaction that Qian Cai reported back > in April [1]. It seemed back then that the problem was fixed, but a few > weeks ago Andrea Arcangeli hit the same bug [2] and there was an additional > discussion at [3]. The earlier version of these fixes had cc:stable. Was the omission this time deliberate?