Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 11 Jan 2021 19:43:57 -0800
From:   Dmitry Torokhov <dmitry.torokhov@gmail.com>
To:     Lubomir Rintel <lkundrak@v3.sk>
Cc:     Souptick Joarder <jrdr.linux@gmail.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: ariel-pwrbutton.c: Remove unused variable
 ariel_pwrbutton_id_table[]
Message-ID: <X/0a/SgL5kWX/7/T@google.com>
References: <1608581041-4354-1-git-send-email-jrdr.linux@gmail.com>
 <CAFqt6zb2O3SFx6xDtwdSgHYH-zeGXwuf1=Hr5yYXnCDqAza9KQ@mail.gmail.com>
 <X/OQZcsD15Fl/XVw@google.com>
 <20210112032028.GB1503339@demiurge.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210112032028.GB1503339@demiurge.local>
Precedence: bulk

On Tue, Jan 12, 2021 at 04:20:28AM +0100, Lubomir Rintel wrote:
> On Mon, Jan 04, 2021 at 02:02:13PM -0800, Dmitry Torokhov wrote:
> > On Tue, Dec 29, 2020 at 01:15:10PM +0530, Souptick Joarder wrote:
> > > On Tue, Dec 22, 2020 at 1:34 AM Souptick Joarder <jrdr.linux@gmail.com> wrote:
> > > >
> > > > Kernel test robot throws below warning ->
> > > >
> > > > >> drivers/input/misc/ariel-pwrbutton.c:152:35: warning: unused variable
> > > > >> 'ariel_pwrbutton_id_table' [-Wunused-const-variable]
> > > >    static const struct spi_device_id ariel_pwrbutton_id_table[] = {
> > > >                                      ^
> > > >    1 warning generated.
> > > >
> > > > Remove unused variable ariel_pwrbutton_id_table[] if no plan to use
> > > > it further.
> > > >
> > > > Reported-by: kernel test robot <lkp@intel.com>
> > > > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> > > 
> > > Any comment on this patch ?
> > 
> > Lubomir, would you prefer to remove the table or add it to the driver
> > structure as ariel_pwrbutton_driver->id_table?
> 
> I believe it can be safely dropped, as the OF match seems to be
> sufficient.
> 
> Thank you for the patch Souptick.
> 
> Reviewed-by: Lubomir Rintel <lkundrak@v3.sk>

Applied, thank you.

-- 
Dmitry