Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750972AbWIKOCw (ORCPT ); Mon, 11 Sep 2006 10:02:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750999AbWIKOCw (ORCPT ); Mon, 11 Sep 2006 10:02:52 -0400 Received: from MAIL.13thfloor.at ([213.145.232.33]:52655 "EHLO MAIL.13thfloor.at") by vger.kernel.org with ESMTP id S1750972AbWIKOCv (ORCPT ); Mon, 11 Sep 2006 10:02:51 -0400 Date: Mon, 11 Sep 2006 16:02:50 +0200 From: Herbert Poetzl To: Pete Zaitcev Cc: "Eric W. Biederman" , Linux Containers , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-usb-devel@lists.sourceforge.net Subject: Re: [PATCH] usb: Fixup usb so it uses struct pid Message-ID: <20060911140250.GA27223@MAIL.13thfloor.at> Mail-Followup-To: Pete Zaitcev , "Eric W. Biederman" , Linux Containers , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-usb-devel@lists.sourceforge.net References: <20060910111249.c2e9c5f2.zaitcev@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060910111249.c2e9c5f2.zaitcev@redhat.com> User-Agent: Mutt/1.5.6i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1547 Lines: 39 On Sun, Sep 10, 2006 at 11:12:49AM -0700, Pete Zaitcev wrote: > On Sat, 09 Sep 2006 22:42:10 -0600, ebiederm@xmission.com (Eric W. Biederman) wrote: > > > The problem by remember a user space process by it's pid it is > > possible that the process will exit, pid wrap around will occur and a > > different process will appear in it's place. > > ... which is completely all right in this case. We used to have an > implementation which tried to hold onto the task_struct and that sucked. > It is only possible for the task to disappear without notifying devio > under very special conditions only, which involve forking with parent > exiting. In other words, even a buggy application won't trigger this > without deliberately trying. And when it happens, uid checks make sure > that other users are not affected. > > > Holding a reference > > to a struct pid avoid that problem, and paves the way > > for implementing a pid namespace. > > That may be useful. > > The patch itself seems straightforward if we can trust your struct > pid thingies. If OpenVZ people approve, I don't mind. perfectly fine from my side best, Herbert > -- Pete > _______________________________________________ > Containers mailing list > Containers@lists.osdl.org > https://lists.osdl.org/mailman/listinfo/containers - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/