Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 11 Jan 2021 22:28:45 -0800
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Xiaoming Ni <nixiaoming@huawei.com>
Cc:     <linux-kernel@vger.kernel.org>, <mcgrof@kernel.org>,
        <keescook@chromium.org>, <yzaikin@google.com>,
        <adobriyan@gmail.com>, <linux-fsdevel@vger.kernel.org>,
        <vbabka@suse.cz>, <mhocko@suse.com>, <andy.shevchenko@gmail.com>,
        <wangle6@huawei.com>
Subject: Re: [PATCH v3] proc_sysctl: fix oops caused by incorrect command
 parameters.
Message-Id: <20210111222845.67ceb4e3c7f64f267756e4e8@linux-foundation.org>
In-Reply-To: <89d1369e-f0a8-66f2-c0ea-3aac3a55e2c1@huawei.com>
References: <20210112033155.91502-1-nixiaoming@huawei.com>
        <20210111203340.98dd3c8fa675b709bcf6d49e@linux-foundation.org>
        <89d1369e-f0a8-66f2-c0ea-3aac3a55e2c1@huawei.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 12 Jan 2021 14:24:05 +0800 Xiaoming Ni <nixiaoming@huawei.com> wrote:

> On 2021/1/12 12:33, Andrew Morton wrote:
> > On Tue, 12 Jan 2021 11:31:55 +0800 Xiaoming Ni <nixiaoming@huawei.com> wrote:
> > 
> >> The process_sysctl_arg() does not check whether val is empty before
> >>   invoking strlen(val). If the command line parameter () is incorrectly
> >>   configured and val is empty, oops is triggered.
> >>
> >> --- a/fs/proc/proc_sysctl.c
> >> +++ b/fs/proc/proc_sysctl.c
> >> @@ -1770,6 +1770,9 @@ static int process_sysctl_arg(char *param, char *val,
> >>   			return 0;
> >>   	}
> >>   
> >> +	if (!val)
> >> +		return -EINVAL;
> >> +
> > 
> > I think v2 (return 0) was preferable.  Because all the other error-out
> > cases in process_sysctl_arg() also do a `return 0'.
> 
> https://lore.kernel.org/lkml/bc098af4-c0cd-212e-d09d-46d617d0acab@huawei.com/
> 
> patch4:
>      +++ b/fs/proc/proc_sysctl.c
>      @@ -1757,6 +1757,9 @@ static int process_sysctl_arg(char *param, 
> char *val,
>              loff_t pos = 0;
>              ssize_t wret;
> 
>      +       if (!val)
>      +               return 0;
>      +
>              if (strncmp(param, "sysctl", sizeof("sysctl") - 1) == 0) {
>                      param += sizeof("sysctl") - 1;
> 
> Is this the version you're talking about?

yes, but as a separate patch.  The bugfix comes first.

> > 
> > If we're going to do a separate "patch: make process_sysctl_arg()
> > return an errno instead of 0" then fine, we can discuss that.  But it's
> > conceptually a different work from fixing this situation.
> > .
> > 
> However, are the logs generated by process_sysctl_arg() clearer and more 
> accurate than parse_args()? Should the logs generated by 
> process_sysctl_arg() be deleted?

I think the individual logs are very useful and should be retained.