Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: KMSAN: kernel-infoleak in move_addr_to_user (4)
To:     Cong Wang <xiyou.wangcong@gmail.com>,
        Jakub Kicinski <kuba@kernel.org>
Cc:     syzbot <syzbot+057884e2f453e8afebc8@syzkaller.appspotmail.com>,
        Robin van der Gracht <robin@protonic.nl>,
        Oleksij Rempel <o.rempel@pengutronix.de>,
        Marc Kleine-Budde <mkl@pengutronix.de>,
        linux-can@vger.kernel.org, David Miller <davem@davemloft.net>,
        Alexander Potapenko <glider@google.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Linux Kernel Network Developers <netdev@vger.kernel.org>,
        syzkaller-bugs <syzkaller-bugs@googlegroups.com>
References: <00000000000019908405b8891f9d@google.com>
 <20210111113059.42de599d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
 <CAM_iQpXbARpYRxFv4g2gC1+oPfdpKx8mMD_7d6BjWr5mPn3nrg@mail.gmail.com>
From:   Oliver Hartkopp <socketcan@hartkopp.net>
Message-ID: <b8606599-22ce-85af-21df-0a1c4a8f174b@hartkopp.net>
Date:   Tue, 12 Jan 2021 10:12:02 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <CAM_iQpXbARpYRxFv4g2gC1+oPfdpKx8mMD_7d6BjWr5mPn3nrg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 12.01.21 01:17, Cong Wang wrote:
> On Mon, Jan 11, 2021 at 11:33 AM Jakub Kicinski <kuba@kernel.org> wrote:
>>
>> Looks like a AF_CAN socket:
>>
>> r0 = socket(0x1d, 0x2, 0x6)
>> getsockname$packet(r0, &(0x7f0000000100)={0x11, 0x0, 0x0, 0x1, 0x0, 0x6, @broadcast}, &(0x7f0000000000)=0x14)
>>
> 
> Right, it seems we need a memset(0) in isotp_getname().

Yes m(

Sent a patch to fix it:

https://lore.kernel.org/linux-can/20210112090457.11262-1-socketcan@hartkopp.net/T/#u

Many thanks!

Oliver