Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp3030160pxb; Tue, 12 Jan 2021 04:47:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJxk5ZjxsEsENPAI81jdOgioUbL6raCW4YqUySnXQfDmzQh3lhqP8LADCngtelviTQiJtr5K X-Received: by 2002:a05:6402:8d9:: with SMTP id d25mr3198719edz.278.1610455626569; Tue, 12 Jan 2021 04:47:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610455626; cv=none; d=google.com; s=arc-20160816; b=hLIeGh/ozyyEAMx/tInEkDlKx2NdPytnofseCMunaMsu7aBgSf03e39P5OkcSUbP2o 3aMZMA08GYsVEV5yVh4yWhpY2/QBy9N2Rsi3C7GnlRFA6u6j+xxT6Xvya0HIKZg0Y4Nf ygVOxbuntCYjpmz8CEss0hQs5UQRp1kQ+Fc9PTrDhlwZ5qeZDjo5+Cbd36vkYNPRVYd/ 7qWMAvl+5B+VZglVGNonCrAMzQYAVHY7Xz86y+laxL81RT0I7EKu4fMZefjPWaxJhR6g wkfDJ7dhEwoq/1xlINko6TcCLW7TVUjT190sYitEpeqbinNPgSsZ4i6+7bBB6jyhnv+I wXXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=WY0WW5EHKFupkTXG0tAM8IVZfwJ+Uxuf/TRpje8+pTA=; b=rg1BKMt/lkZ2SJR4wk/tUw9MrVtDiBPG3lzW2cSAVHKyML0m4aWkRe1fh1SkXLxWBr VYvMnudJR61Uksl/XxYKs8TLK+cawzLovjpIvptSFGP0z39Vm4FKyGSRVapb1YzPqDgq ii/QUHIIa3vDH2t1/y7tWGbIh9v+qpuu1TJ9bJOM/9nJbM1GWQm6rnRz+7aFrCfhf0bk EtCcng+pKTv/G4iDck76JnlxEyeior6AKv2w49RtOTQmbbqdXCvIm+yt+CPUjFfONxsQ ciE2YKeuvWNe3i/yhznBJgKKetgfiDuukE+I8UPcQUhGdklhPxMT941YB0Gu94sbinw2 y5RA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=uI2ebsQM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r12si1053608ejs.382.2021.01.12.04.46.43; Tue, 12 Jan 2021 04:47:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=uI2ebsQM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404601AbhALKPm (ORCPT + 99 others); Tue, 12 Jan 2021 05:15:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404514AbhALKPl (ORCPT ); Tue, 12 Jan 2021 05:15:41 -0500 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 241A6C061794 for ; Tue, 12 Jan 2021 02:15:01 -0800 (PST) Received: by mail-wr1-x42f.google.com with SMTP id a12so1847077wrv.8 for ; Tue, 12 Jan 2021 02:15:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=WY0WW5EHKFupkTXG0tAM8IVZfwJ+Uxuf/TRpje8+pTA=; b=uI2ebsQMDG30pspMoXDv8UlypbDCL4LjY5BPJlr2UNXHq0psmlBpsKKpama2nheNWC sbl199nWsvpUhIIe17kDORY49WL216kYBxT4OIxza8SHaPpBwHF/OgfaU+qqtoaWYj1B TkpuIGpCK4NZGBIzzLewXvHeFVI1jd03yYR2MbzOtxzqBRkahc7dRNXToRRRsv8MmJvU WgkC07qsXKhyFhZhXMWGOHp6TQncHI/zDnFX/RajIa277O6ZNPjyS1zMNv6IJnTKYPYx RXql/q4II0Xa17gyWbGTPG4IR9fhNQ+yGi6HlPNs6LOXTOeyucPhUQlP/y8MO/9p5Qsk hGDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WY0WW5EHKFupkTXG0tAM8IVZfwJ+Uxuf/TRpje8+pTA=; b=Y9lsohmLnQgz1OZiKOc1rBAf8gULXtG2JxGLtaHG5PS9p/11X0OoPGK9rhAMF0u2Bx 0dzWVsZK4ghMi3NghXIHTUw2bZxEfeNNnsy/P7YrjvZAAzak5Qlx19i8c+6OwK8eTwIh vWLPtA2xhq6GBFOgSL020qOCu+JDv6bGklQbIgh15PwUlVG8mERlyxbHWcbVr8pQY9lP zOmKEzCnN01O0jAkaXK7fnSOeDCU3vyOdiGt2NIdn6ey60tYqH4jTmmqZIzuLouJlqfl 1Ncthhvy2vjrrjA303OjNbTUGKg3mcDqjubYfUarqfGI4HIV/6pzjiZDoyCvNxzH6dwp IS2g== X-Gm-Message-State: AOAM532sOxixji/HUZPXqNs9XYK6BD6ySdmPn8CYG3nZM+25tnDStEWW pqslv3X8mVxlkIT857iJbNo= X-Received: by 2002:adf:dcc5:: with SMTP id x5mr3421302wrm.167.1610446499920; Tue, 12 Jan 2021 02:14:59 -0800 (PST) Received: from smtp.gmail.com (a95-92-181-29.cpe.netcabo.pt. [95.92.181.29]) by smtp.gmail.com with ESMTPSA id g5sm4426125wro.60.2021.01.12.02.14.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jan 2021 02:14:59 -0800 (PST) Date: Tue, 12 Jan 2021 07:14:53 -0300 From: Melissa Wen To: Sumera Priyadarsini Cc: rodrigosiqueiramelo@gmail.com, hamohammed.sa@gmail.com, daniel@ffwll.ch, airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V5 3/3] drm/vkms: Add information about module options Message-ID: <20210112101453.3ofinorxbe4ylvob@smtp.gmail.com> References: <4fbc6459377c1dcbe8e6648718453d5693f6451c.1610391685.git.sylphrenadin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4fbc6459377c1dcbe8e6648718453d5693f6451c.1610391685.git.sylphrenadin@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/12, Sumera Priyadarsini wrote: > Update vkms documentation to contain usage of `modinfo` > command and steps to load vkms with module options enabled. > > Signed-off-by: Sumera Priyadarsini > --- > Documentation/gpu/vkms.rst | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/Documentation/gpu/vkms.rst b/Documentation/gpu/vkms.rst > index 9e030c74a82e..2c9b376da5ca 100644 > --- a/Documentation/gpu/vkms.rst > +++ b/Documentation/gpu/vkms.rst > @@ -35,6 +35,18 @@ Now, to load the driver, use:: > On running the lsmod command now, the VKMS driver will appear listed. > You can also observe the driver being loaded in the dmesg logs. > > +The VKMS driver has optional features to simulate different kinds of hardware, > +which are exposed as module options. You can use the `modinfo` command > +to see the module options for vkms:: > + > + modinfo vkms > + > +Module options are helpful when testing, and enabling modules > +can be done while loading vkms. For example, to load vkms with cursor enabled, > +use:: > + > + sudo modprobe vkms enable_cursor=1 > + Hi Sumera, Thanks for documenting. You forgot to bring Daniel's ack; however, as I also reviewed and lgtm, Reviewed-by: Melissa Wen > To disable the driver, use :: > > sudo modprobe -r vkms > -- > 2.25.1 >