Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp3031739pxb; Tue, 12 Jan 2021 04:49:55 -0800 (PST) X-Google-Smtp-Source: ABdhPJwkUzmvTzckiaFu9oWy7A4y6h1rDeWUQL80PWqIYinbckRBEUnwkTTb7IBU04MdVe9G0yjt X-Received: by 2002:a17:906:ae42:: with SMTP id lf2mr1552742ejb.487.1610455795419; Tue, 12 Jan 2021 04:49:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610455795; cv=none; d=google.com; s=arc-20160816; b=YJuwvi2GPeAQBC0ROtOQ2L3sFijHBP2uWVH5rVgB4Re33qk1K7ljIiNcmCRYjezSY1 /2Jo9xhSrBSDjDwZonwrmAmlMkjfib0jTayaAgGU72+yJlgPr0ffFRgfmaufIY908u9T HvLTPLQ6gNANDBSCxcaDE78NGHhQXyuIwWbdH24aQ1mJfbJBSP1dqnKRUTLiGXJfcGNF poR1YNe48MkJzWDPYjUs+Dnf9frJPOVPwk4j26vD40suDoA3wXJFO5HtuCkn2eGGYxrg Bje4j447+WvI6exMaMYxglxrzgI6wb2Lh+lsQYpqXTZawV9nZVFk9JuatY7g6Saw5DRb BI/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=NJJVM3tMsAbPPewQAkM2Rg5hr+uJt7QVNc6BTT5p6xk=; b=C361lt9jdlPX64/Qjdu+okYBzAUMQlJ+k72f3xLhXYW3OlnYtWozRAgcRQfzVcrkFi iKGpLjQlYVHHePOPckpZ/C9BptuU3uNg1LJtZCTbMVhtbAsGKXf0WzscJvAbKn2Xy8gV YCLd9tzIJCeOGcsL13sct/VdTYdXFKV9kOj0ngBeh+JFd0rjYXf2H5ukfk54Ymkardnq YjetgvzLv6IldP4irjMc7/btQL/4YyBPuCyGkJeA96dtOaTrWvCcDE/hD1rd0OPBYhpe NmyZxXK7r1OAg4BEmzW+OwEnEwr3fnpLVwnrgqFigLUUL/3QbV1XKZtVgafrRVrlt5Gd noLw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id sa14si1066799ejb.54.2021.01.12.04.49.31; Tue, 12 Jan 2021 04:49:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404906AbhALKUW (ORCPT + 99 others); Tue, 12 Jan 2021 05:20:22 -0500 Received: from mx2.suse.de ([195.135.220.15]:34436 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404579AbhALKUW (ORCPT ); Tue, 12 Jan 2021 05:20:22 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id AAD34B81F; Tue, 12 Jan 2021 10:19:40 +0000 (UTC) Date: Tue, 12 Jan 2021 11:19:38 +0100 From: Oscar Salvador To: Dan Williams Cc: linux-mm@kvack.org, David Hildenbrand , Michal Hocko , vishal.l.verma@intel.com, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/5] mm: Move pfn_to_online_page() out of line Message-ID: <20210112101938.GB12534@linux> References: <161044407603.1482714.16630477578392768273.stgit@dwillia2-desk3.amr.corp.intel.com> <161044408207.1482714.1125458890762969867.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <161044408207.1482714.1125458890762969867.stgit@dwillia2-desk3.amr.corp.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 12, 2021 at 01:34:42AM -0800, Dan Williams wrote: > pfn_to_online_page() is already too large to be a macro or an inline > function. In anticipation of further logic changes / growth, move it out > of line. > > No functional change, just code movement. > > Cc: David Hildenbrand > Reported-by: Michal Hocko > Signed-off-by: Dan Williams Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE L3