Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210107181524.1947173-1-geert+renesas@glider.be>
 <20210107181524.1947173-3-geert+renesas@glider.be> <20210112101950.GK2771@vkoul-mobl>
 <CAMuHMdXhKpO4RLXVBzVezSnui3ZvgB5oX-n25Mcj7se0PaX78A@mail.gmail.com> <20210112103831.GM2771@vkoul-mobl>
In-Reply-To: <20210112103831.GM2771@vkoul-mobl>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Tue, 12 Jan 2021 11:48:27 +0100
Message-ID: <CAMuHMdX0DMBcdfQbx5jc_3keMdF2YjefLHhF69kEhJuCqsYQ+w@mail.gmail.com>
Subject: Re: [PATCH 2/4] dmaengine: rcar-dmac: Add for_each_rcar_dmac_chan() helper
To:     Vinod Koul <vkoul@kernel.org>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Dan Williams <dan.j.williams@intel.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
        Phong Hoang <phong.hoang.wz@renesas.com>,
        dmaengine <dmaengine@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Vinod,

On Tue, Jan 12, 2021 at 11:38 AM Vinod Koul <vkoul@kernel.org> wrote:
> On 12-01-21, 11:26, Geert Uytterhoeven wrote:
> > On Tue, Jan 12, 2021 at 11:19 AM Vinod Koul <vkoul@kernel.org> wrote:
> > > On 07-01-21, 19:15, Geert Uytterhoeven wrote:
> > > > Add and helper macro for iterating over all DMAC channels, taking into
> > > > account the channel mask.  Use it where appropriate, to simplify code.
> > > >
> > > > Restore "reverse Christmas tree" order of local variables while adding a
> > > > new variable.
> > > >
> > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > > > --- a/drivers/dma/sh/rcar-dmac.c
> > > > +++ b/drivers/dma/sh/rcar-dmac.c
> > > > @@ -209,6 +209,11 @@ struct rcar_dmac {
> > > >
> > > >  #define to_rcar_dmac(d)              container_of(d, struct rcar_dmac, engine)
> > > >
> > > > +#define for_each_rcar_dmac_chan(i, chan, dmac)                                \
> > > > +     for (i = 0, chan = &(dmac)->channels[0]; i < (dmac)->n_channels; \
> > > > +          i++, chan++)                                                \
> > >
> > > single line to make it more readable? we have limit of 100 now :)
> >
> > Do we have to push the limits?
>
> In cases where it helps, I certainly recommend.. I feel in this case it
> makes a better read to have it in a single line..

OK, will fix.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds