Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp3039701pxb; Tue, 12 Jan 2021 05:02:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJxZtaxponZQzkvD8WmEJrVH+X9ftQn4GkX/22ELJUbrAKrdjAeFC1KxRSuKK90dRBf0210N X-Received: by 2002:a17:906:d93c:: with SMTP id rn28mr3159849ejb.50.1610456545497; Tue, 12 Jan 2021 05:02:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610456545; cv=none; d=google.com; s=arc-20160816; b=r2EwpYoTe6l9pZasKnVxmgda1e4s5V2wMHcANDYNZDVrmg3WnLK2v1aUWp/KRvGSoU ks/ViHlgYseeIA1+knPlIAMoh/tcJbN2mr5sPvCPBKWEEzUVvPpgQMPtazKdwxEHNGGd JFI2EZ3g8bXf1iK13ZN8CJhF/kNluBcZB3LSetFLjMSHTosF8Y5lqd0Y2qyLHobzWA75 utcwqPIQPtLF55z6jc2cHaMl39rE8PbuQbjktn1xbTeHzmXGVfnr6FmOpVyYFMY7Hywy mRRzknzruUBwgz15VNa7xaWtl6vgE9bZH+ZSMHt0d78oaNjr4Q3qN2FljU/uaDTRX5C2 +qvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=APm8lNC6tsRthrKHh8x0lk8XwUZfEnqHf3TxruRpXZ4=; b=K4HeLCIZDtXn2edeMhHXt4W/ka/9KubXllRGymohOM7v0vXxt2TCAUsjfmvgxxRF7H h77uALH/W2Je5cNZx/LpzcGMYjH4l+dm3s52jtN7wNNqJ6CNOSe97S8OOA9lQ2BsUaNZ 6sGXw5pqhrATmSuP4mF6AX7QeM8lMLA9BYL7f//lEkugxmX7kHq403KHQFgM8fsR2tcu fxWWxhvaoYVGO9oDSJ7Ea6O4PaE88hUnXQfoKx9FLjT/mMiDPYeL3iPNJ3HM4zWRf3Q9 vCgbrVxOs4fBEa3gnuzlNNlsKNZqV5i4CrR6HBwntOEgdXhDai2civYy2gJORp/F0nWc dvtg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ezcp3LJT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hq36si1063427ejc.590.2021.01.12.05.02.00; Tue, 12 Jan 2021 05:02:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ezcp3LJT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726379AbhALLQJ (ORCPT + 99 others); Tue, 12 Jan 2021 06:16:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725863AbhALLQI (ORCPT ); Tue, 12 Jan 2021 06:16:08 -0500 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07E6AC061575; Tue, 12 Jan 2021 03:15:28 -0800 (PST) Received: by mail-lf1-x12a.google.com with SMTP id x20so2730469lfe.12; Tue, 12 Jan 2021 03:15:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=APm8lNC6tsRthrKHh8x0lk8XwUZfEnqHf3TxruRpXZ4=; b=ezcp3LJTzPcczKona/Bt7HXW9eKYs3l+I/MdzAJbhSXJxOt+oNB1IRAkWOPd18T5cq URWcfZn/TRvkAEX/29SzrDurPEUMWH+IztWozHqYOJWn6bkzJ7/SnN2HmKsGzJxkW4cq 8IHUJO5xCNvOA3FNs957idAWK6yTJ+pcwZ+SuTt5jXRbVKctLTnNT567OmK+YF0WFPVm bB6zhPmK+DXnCwrssHrTXNJJ5vbE15xcOCbG/2sOAgRI+3oTDjKHMO4Pb1gTsYDgbPW4 RGKE0lrPFw5fTv8jMg5xCjF0sy1ReLAyOu8gDUw8ZIPEOZee3LXQR16fNbu9crYeSYM9 Om7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=APm8lNC6tsRthrKHh8x0lk8XwUZfEnqHf3TxruRpXZ4=; b=dQKiZxJJD4mAZg6mfkx+ilfEFru9Ndu8S6Na85L8HhYZ28DsCLQBmttKalsunQw+MD o0hj9dmlbHQloDlECZMYJ3isSKNLBuE2pvKDxcQfOISPkXZjLpvKQL9QtC8x5BOsk9ps CS+mCxARA1/Q9026rcsAnygmYjuMEDhzRN2yjZ0QSKy1Aoz++N2emkE3nATv+4/565Qs B8t9IAzlwEl8Y10gpq+1jZf/1jFmGjE4H2eNo4tgX+nquiyYivuOnSGrIQjhhHZE96rs MnSwK9Q9Tq0epzKmvbzKXEfsNp+24FCEjSjydudgntz7dQQWihF76zKerJ3gakKIOJPd g34Q== X-Gm-Message-State: AOAM533qmJaRUMCdQgIOpik9/7xp3btRSdFg0e1PZhbCMi8V77kKug7w xUQYLTAgNelCIwdpaTZtsOQUWSZ2+Wo8qw== X-Received: by 2002:a19:cc56:: with SMTP id c83mr1950431lfg.341.1610450126569; Tue, 12 Jan 2021 03:15:26 -0800 (PST) Received: from [192.168.1.101] ([178.176.77.112]) by smtp.gmail.com with ESMTPSA id 10sm352059lfh.208.2021.01.12.03.15.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Jan 2021 03:15:26 -0800 (PST) Subject: Re: [PATCH] ata: remove redundant error print in rb532_pata_driver_probe To: menglong8.dong@gmail.com, axboe@kernel.dk Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Menglong Dong References: <20210112023619.5713-1-dong.menglong@zte.com.cn> From: Sergei Shtylyov Message-ID: <33bb1cd2-c202-0fd5-733d-b44e7e8fa92c@gmail.com> Date: Tue, 12 Jan 2021 14:15:25 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210112023619.5713-1-dong.menglong@zte.com.cn> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! On 1/12/21 5:36 AM, menglong8.dong@gmail.com wrote: > From: Menglong Dong > > Coccinelle reports a redundant error print in rb532_pata_driver_probe. > As 'platform_get_irq' already prints the error message, error print > here is redundant and can be removed. > > Signed-off-by: Menglong Dong > --- > drivers/ata/pata_rb532_cf.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/ata/pata_rb532_cf.c b/drivers/ata/pata_rb532_cf.c > index 479c4b29b856..dcde84f571c4 100644 > --- a/drivers/ata/pata_rb532_cf.c > +++ b/drivers/ata/pata_rb532_cf.c > @@ -115,10 +115,8 @@ static int rb532_pata_driver_probe(struct platform_device *pdev) > } > > irq = platform_get_irq(pdev, 0); > - if (irq <= 0) { > - dev_err(&pdev->dev, "no IRQ resource found\n"); > + if (irq <= 0) > return -ENOENT; This still beaks the probe deferral. :-( But that's another problem... [...] MBR, Sergei