Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964950AbWIKQEm (ORCPT ); Mon, 11 Sep 2006 12:04:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964954AbWIKQEm (ORCPT ); Mon, 11 Sep 2006 12:04:42 -0400 Received: from smtp.osdl.org ([65.172.181.4]:16820 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S964950AbWIKQEk (ORCPT ); Mon, 11 Sep 2006 12:04:40 -0400 Date: Mon, 11 Sep 2006 09:04:24 -0700 (PDT) From: Linus Torvalds To: Jens Axboe cc: Alan Cox , Jeff Garzik , Sergei Shtylyov , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: What's in libata-dev.git In-Reply-To: <20060911153706.GE4955@suse.de> Message-ID: References: <20060911132250.GA5178@havoc.gtf.org> <45056627.7030202@ru.mvista.com> <450566A2.1090009@garzik.org> <450568F3.3020005@ru.mvista.com> <1157986974.23085.147.camel@localhost.localdomain> <45057651.8000404@garzik.org> <1157988513.23085.159.camel@localhost.localdomain> <20060911153706.GE4955@suse.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1204 Lines: 30 On Mon, 11 Sep 2006, Jens Axboe wrote: > > So this is a confirmed, broken case? Why has no one complained for 2.4 > and 2.6? Oh, I didn't even notice that we do that by default already. That's a bit scary - I remember people having their disks trashed. Maybe the broken disks are old enough to not be an issue any more, or maybe something else makes it effectively impossible to trigger in practice? You do need to get 32 pages of contiguous IO for it to happen, and while I don't see anything else that would limit it, maybe there is something that does? (Some other limiter like max_phys_segments might, but that particular one defaults to much more than 32) Of course, we do hopefully handle requests that fail a lot more gracefully these days, so if the drive says it didn't do it, maybe we just fix it up properly, in a way we didn't use to.. Ie we may have fixed the thing that caused corruption just by fixing something else ;) Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/