Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp3043122pxb; Tue, 12 Jan 2021 05:06:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJxlsZAVRLVuX0ZHwRTwM1bPPeeexh1UgFdYXh3r43CWAOuvyC719g8PvZgokTdHMOQuRv4K X-Received: by 2002:a17:906:878d:: with SMTP id za13mr3134498ejb.395.1610456789580; Tue, 12 Jan 2021 05:06:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610456789; cv=none; d=google.com; s=arc-20160816; b=uLFg+QKO9mgM89x7wBvHCijW6DzRx5m86F4TeUjHKMxj1SfanWkPogpA1Q0370qERM KfAqGYIWEcM7o6NL9hvNNR85WXpVKgiGHMMvAlQfTmmUA0SieVV1EKUryjsT68BJa8bV CpsnCm4azz8l+aWXgfoOObRCh/FDoTX0oa9URmQBW33zLBrJBpN7mgcNVDWjhlUknt7e SW7880FHzmYqOKTHbgLtERwQokUwDdg1yQq16T0+/AbK5HM00MuUfoaJWh6YWvMlDx1x 2BN4xl5Db9WktFO2mr1n1RNTaoAEbN6REzOxY4VnPcEujiDUna6aKooOMS4Iic/P+yjM lsYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=CB1nlJyt2/oAlpzr0sBox8s5QaP5vvunp1HV72G1cmk=; b=f4eU3ZJ9GcDq80X5zZISkZD0Vkf75yOrov3WZSijS8G1DQS4wAS/seJskO+5XUvlvW kq6cOgY0gQnD8gvkEt64ehgxlgIQ3lAOWvtQWVRXpJ40ZWMEE0/iWxKWd1e4UVUfDnrN P6IgftbaZ2SKagI44LxdrAihKOYxvpMvuc0M5wewP9HRD3a6UDVn44jHwALb0eB1JUn2 9BwkZLdpeAO6Ri1Wvz4wfUqmbGOF7pPYouqTZjmHFgVMaAHX+RcnIkC4lFDtDPVCvU0m FOJUBflZiGSDPoHmAijtEgz4RhnPlXWtd1T4X1DunNwXmYQEkf0iKILMdvGtT//OFm1Z krzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=a9KJlctw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t21si1302835eds.390.2021.01.12.05.06.04; Tue, 12 Jan 2021 05:06:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=a9KJlctw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732152AbhALMGQ (ORCPT + 99 others); Tue, 12 Jan 2021 07:06:16 -0500 Received: from mail.kernel.org ([198.145.29.99]:41262 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725843AbhALMGQ (ORCPT ); Tue, 12 Jan 2021 07:06:16 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5D1A722EBE; Tue, 12 Jan 2021 12:05:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1610453135; bh=mI4rHP50fccUJxrpr2+kl7js5/5KSgQaYpoCvv6emKU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=a9KJlctw3nuOjkz173EVSFcwQ0JCUfMFRGFgvkz8/WyLYbZjhkf4OXEdPq+tfarXX efZOL9fJskx6qhpaKEmABB/6GDjewT9C2hjU/e9VPJTdiziNJscR4FzFeK98zgRGoj yNBPIFAVTCPJ/8kFc8WkYkpcPj7nDAoYEHgsjvzI= Date: Tue, 12 Jan 2021 13:06:44 +0100 From: Greg KH To: Hans de Goede Cc: Kyle Tso , linux@roeck-us.net, heikki.krogerus@linux.intel.com, badhri@google.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 0/3] AMS, Collision Avoidance, and Protocol Error Message-ID: References: <20210105163927.1376770-1-kyletso@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 12, 2021 at 12:57:28PM +0100, Hans de Goede wrote: > Hi, > > On 1/12/21 12:53 PM, Greg KH wrote: > > On Wed, Jan 06, 2021 at 12:39:24AM +0800, Kyle Tso wrote: > >> This series include previous patch "[v4] AMS and Collision Avoidance" > >> https://lore.kernel.org/r/20201217030632.903718-1-kyletso@google.com > >> and two more patches "Protocol Error handling" and "Respond Wait if...". > >> > >> The patch "AMS and Collision Avoidance" in [v5] is the same as the one > >> in [v4] (only rebased to ToT). > >> > >> The patch "Protocol Error handling" is based on PD3 6.8.1 to fix the > >> wrong handling. > >> > >> The patch "Respond Wait if..." is to fix a conflict when > >> DR/PR/VCONN_SWAP occurs just after the state machine enters Ready State. > >> > >> Kyle Tso (3): > >> usb: typec: tcpm: AMS and Collision Avoidance > >> usb: typec: tcpm: Protocol Error handling > >> usb: typec: tcpm: Respond Wait if VDM state machine is running > >> > >> drivers/usb/typec/tcpm/tcpm.c | 925 +++++++++++++++++++++++++++++----- > >> include/linux/usb/pd.h | 2 + > >> include/linux/usb/tcpm.h | 4 + > >> 3 files changed, 792 insertions(+), 139 deletions(-) > > > > Heikki, any thoughts about this series? > > Note I plan to test this series on a device with a fusb302 Type-C > controller, where it broke role-swappings in a previous version of > this series. This is supposed to be fixed now but I would like to > confirm this. > > I've had this on my todo list for a while now. I've > now put this in my calendar as a task for tomorrow. So please wait > till you hear back from me (hopefully with a Tested-by) with > merging this, thanks. No worries, just wanted to make sure it didn't fall through the cracks. thanks for testing! greg k-h