Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp3044938pxb; Tue, 12 Jan 2021 05:08:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJxdDtEAEaGwMf/flcIVFUYGnHQz9FYwIysKBm8nzc8hK1ei+ZLAugC2SnyvneXDYhzB6HwO X-Received: by 2002:a17:906:710b:: with SMTP id x11mr3295718ejj.433.1610456928373; Tue, 12 Jan 2021 05:08:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610456928; cv=none; d=google.com; s=arc-20160816; b=Lm3kpVxxqg4cVLjfPX06Y4S0JsfaEOImAHL/bEnZagnO3jQMEUnVZgjMM9aes/L8vm rImvk/ZQhQNRu9NZN03JCULdjcKNGLl0AUMpaS8Vzww9b/xExYwJAl0lQU4KYRGVZlUk fcjfV/0PKRnfiFo9CTds19Uo4+smjVOl676f6CwqAi9RZs+M4B3zhULdQ7DaNoO6xFUW lq3qYZV7ec/ErX97c/Afl/DYV6ymMY0r+vhE9PG2o0GI0P8zgi/z59fKnP6nIAVvHWwI tUlVcGmM+N1bTe7fC+hRf4tQ1clhCH0On51/JFO8P1qZl9AJ2tlLFKf75EFiWJrxycpo SGig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dmarc-filter:sender :dkim-signature; bh=d9KzsDSUDaQzJ4IsFtpJ8BDiKCJOeDvBmZqSm7dAx6c=; b=ZaxHLybg7Z9Hr0rucgISwiYbKzbQzwRlmv1AqJZA7W6EvSlg3E4vuLcyHJx8dIalvH XEpPgPA5aLFYzvSMj7EkfRCEWEmoHf1MqhWtmDt6RP/N+gWkRE7jVi53+KKZXRF9vdTu 5jfDDS5YOaFEU74N5ujHpw8G77UMZT3VES60C3wUdPi8no9gdcN/GnLOuCsoz3nnTe5S cqXxsc8OpmAs3czHhDYVxwQsTMTDvaeM43VGQw3OdW7dixOmXe8EC6RVXcs/eBY0WvUt hp///N3/qXLkknk4cCPID4v8RERPT40I3ARANCj2m5BDaDFDP66XZIr8i6aIQHY8A9zg N/9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=QS0hT4YF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z6si1114386ejw.244.2021.01.12.05.08.23; Tue, 12 Jan 2021 05:08:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=QS0hT4YF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388469AbhALMq6 (ORCPT + 99 others); Tue, 12 Jan 2021 07:46:58 -0500 Received: from so254-31.mailgun.net ([198.61.254.31]:40202 "EHLO so254-31.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388394AbhALMqz (ORCPT ); Tue, 12 Jan 2021 07:46:55 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1610455594; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=d9KzsDSUDaQzJ4IsFtpJ8BDiKCJOeDvBmZqSm7dAx6c=; b=QS0hT4YFLf8dUAuAlYuTb0zAvCUUDTir+c4QLEx9QbYKANVq8oVXLF5aIklIhCVdnbIILS9z WRlSmGt45rbKalkFExWcuKX2eFaDkh7mHa2DDf2JZAtXb1MTDXc0Qa3O1cOxuyHscVqs1BEm ckEuCp0ewsJtu7TUKSn7TjcnpyI= X-Mailgun-Sending-Ip: 198.61.254.31 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-east-1.postgun.com with SMTP id 5ffd99f4c88af061075d8f20 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 12 Jan 2021 12:45:40 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 3C5C0C433CA; Tue, 12 Jan 2021 12:45:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 7F157C433C6; Tue, 12 Jan 2021 12:45:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 7F157C433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Takashi Iwai Cc: Michal Kubecek , linux-wireless@vger.kernel.org, Mordechay Goodstein , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Arjen de Korte , Luca Coelho Subject: Re: regression in iwlwifi: page fault in iwl_dbg_tlv_alloc_region() (commit ba8f6f4ae254) References: <20201228115814.GA5880@lion.mk-sys.cz> <87v9c2qtj9.fsf@tynnyri.adurom.net> Date: Tue, 12 Jan 2021 14:45:33 +0200 In-Reply-To: (Takashi Iwai's message of "Tue, 12 Jan 2021 13:35:05 +0100") Message-ID: <87v9c2ias2.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Takashi Iwai writes: > On Tue, 12 Jan 2021 12:33:14 +0100, > Kalle Valo wrote: >> >> (adding luca) >> >> Michal Kubecek writes: >> >> > FYI, there is a regression in iwlwifi driver caused by commit >> > ba8f6f4ae254 ("iwlwifi: dbg: add dumping special device memory") >> > reported at >> > >> > https://bugzilla.kernel.org/show_bug.cgi?id=210733 >> > https://bugzilla.suse.com/show_bug.cgi?id=1180344 >> > >> > The problem seems to be an attempt to write terminating null character >> > into a string which may be read only. There is also a proposed fix. >> >> Can someone submit a proper patch, please? See instructions below how to >> submit. >> >> And please add Fixes tag to the commit log: >> >> Fixes: ba8f6f4ae254 ("iwlwifi: dbg: add dumping special device memory") > > OK, I'll do it for my own Thanks. > but really I hoped that someone would have reacted on the bugzilla > report before the official patch submission. So far no one from the > upstream devs showed interest in the bug at all, unfortunately. Bugzilla is problematic as I don't know if anyone tracks it actively, at least I don't have time for that. I recommend reporting all wireless issues to mailing lists to make sure everyone see it. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches