Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 12 Jan 2021 12:22:45 +0000
From:   Matthew Wilcox <willy@infradead.org>
To:     Faiyaz Mohammed <faiyazm@codeaurora.org>
Cc:     cl@linux.com, penberg@kernel.org, rientjes@google.com,
        iamjoonsoo.kim@lge.com, akpm@linux-foundation.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        vinmenon@codeaurora.org
Subject: Re: [PATCH] mm: slub: Convert sys slab alloc_calls, free_calls to
 bin attribute
Message-ID: <20210112122245.GK35215@casper.infradead.org>
References: <1610443287-23933-1-git-send-email-faiyazm@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1610443287-23933-1-git-send-email-faiyazm@codeaurora.org>
Precedence: bulk

On Tue, Jan 12, 2021 at 02:51:27PM +0530, Faiyaz Mohammed wrote:
> @@ -5180,6 +5187,7 @@ static int any_slab_objects(struct kmem_cache *s)
>  
>  struct slab_attribute {
>  	struct attribute attr;
> +	struct bin_attribute bin_attr;
>  	ssize_t (*show)(struct kmem_cache *s, char *buf);
>  	ssize_t (*store)(struct kmem_cache *s, const char *x, size_t count);
>  };

I'd rather you added a struct slab_bin_attribute.  If that's even
needed ..  I think you could just use the bin_attribute directly instead
of embedding it in this struct.