Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 12 Jan 2021 14:00:37 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Takashi Iwai <tiwai@suse.de>
Cc:     Peter Geis <pgwipeout@gmail.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Peter De Schrijver <pdeschrijver@nvidia.com>,
        Prashant Gaikwad <pgaikwad@nvidia.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Sameer Pujar <spujar@nvidia.com>,
        Mohan Kumar <mkumard@nvidia.com>, linux-clk@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
        alsa-devel@alsa-project.org
Subject: Re: [PATCH v2 0/2] fix tegra-hda on tegra30 devices
Message-ID: <X/2ddbamUzXECZDT@ulmo>
References: <20210108135913.2421585-1-pgwipeout@gmail.com>
 <s5hv9c2sgxd.wl-tiwai@suse.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="drqTfn9TqBQMdij7"
Content-Disposition: inline
In-Reply-To: <s5hv9c2sgxd.wl-tiwai@suse.de>
User-Agent: Mutt/2.0.3 (a51f058f) (2020-12-04)
Precedence: bulk


--drqTfn9TqBQMdij7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 12, 2021 at 09:22:38AM +0100, Takashi Iwai wrote:
> On Fri, 08 Jan 2021 14:59:11 +0100,
> Peter Geis wrote:
> >=20
> > The following patches fix tegra-hda on legacy tegra devices.
> > Two issues were discovered preventing tegra-hda from functioning:
> > -The hda clocks on tegra30 were assigned to clk_m and running at too low
> > of a rate to function.
> > -The tegra-hda encounters an input/output error when opening a stream.
> >=20
> > Since the only mainline device that used tegra-hda until recently was t=
he
> > t124, it is unknown exactly when this was broken. Fortunately a recent
> > patch was submitted that fixed the issue only on t194 devices. We can
> > apply it to the tegra30-hda device to resolve the issue across the boar=
d.
> > Note that downstream devices used the spdif device instead of hda for h=
dmi
> > audio. The spdif device lacks a driver on mainline.
> >=20
> > -Checkpatch seems to have issues finding [1], but git show has no issue.
> > [1] commit 60019d8c650d ("ALSA: hda/tegra: workaround playback failure =
on
> > Tegra194")
> >=20
> > Changelog:
> >=20
> > v2:
> > -Added ack and reviewed-by from Jon
> > -Updated fix to apply to tegra30-hda vice universally (Thanks Jon)
> > -Updated commit to include comments from hardware team (Thanks Sameer)
> > -Cleaned up commit messages
> >=20
> > Peter Geis (2):
> >   clk: tegra30: Add hda clock default rates to clock driver
> >   ALSA: hda/tegra: fix tegra-hda on tegra30 soc
>=20
> Shall I apply both patches via sound git tree?
>=20
> Or, if you want to take through clk tree, let me know.  In that case,
> feel free to take my ack:
> Acked-by: Takashi Iwai <tiwai@suse.de>

There doesn't seem to be a build-time (or even runtime) dependency
between the two patches and they fix two independent issues, so they
could also go in separately.

I'm fine either way. From a Tegra perspective, the Tegra30 clock driver
is very low activity, so I don't expect any conflicts with between this
and some other patches that might go in through the clock tree.

Thierry

--drqTfn9TqBQMdij7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl/9nXUACgkQ3SOs138+
s6GqTg/+OADUywchD2A60VkcQ2urUoARq6t0hydg25Ly37rjRWhl92PWQ9V3YULd
HZAA38q+/PzszkSs0ivCRKPV9QPz/YjOjpJgR3XX0GSOCxXMzxcni4GKQ5p06BsG
hCadEe1K+YXSznQn1hX6hjuuPWjSs2ZijMM/yTILil0fAd5P4LTxkbuGgxwFPXPf
/g2j/KY1IYwPotwYuOdn9eakJJaHTZJAV3pO6eDiJ+WYC4u0tPZLiCtozSSPxCAF
IZJZuBzFiMgurxjTMIlQW82Mn0R7Bpr9ERlAGIVGaPMKOugajQV/lg9223SHPlei
4tnGIU6Ven7HhFQYWxvzV32GFiuNorsSDMbCAqObPglo30Qt0jSW+DDEn9ymb9rg
owNjg8+7+uckLTRggIWoMv5eG2gh+inGOE31uNx5umn0U72JVAqjjM2YgCA5+nB4
G8lHQXFsEM4phFj+SwH1mT1u8xBeEQ5FB++hHZGX6Q3UQe4XN8w2JRAwroGRsupS
oan0d5kY0aSxzRxqXRbAFFt6SmkV+1vH1Qt0NrjAji9k9jEw/8kHcgeEEG52mHZe
c4ykdSeLwM40vCLLjAH5frO0mCGwy87y7epP8fq9t2mAFhnE6te1JZZh2d66mH7k
y3qIffocs2VEyxyMnK+EPceKMMDCg09LerCkt7ON2gde9ymVANk=
=csJX
-----END PGP SIGNATURE-----

--drqTfn9TqBQMdij7--