Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp3060813pxb; Tue, 12 Jan 2021 05:31:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJypqGtpSUz0xLpP2LU1kut24XqcAwsWP4jk7YVOXg5thpC5PZ1dsbVwFoB37Jj+Exw/24ib X-Received: by 2002:a17:906:410e:: with SMTP id j14mr3233219ejk.253.1610458276270; Tue, 12 Jan 2021 05:31:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610458276; cv=none; d=google.com; s=arc-20160816; b=kOTZ36psxlBVuQl+Mex9Xyq/i+teSe41yFbgUHGEBQPxaD1Mh9zyB/yLQfS9lFydIp eny2TWPRQDsAussTZwzh6o4iOU7dLbrZ9cSigTiE2ncnM0ImRTzfSieBHoiErQwSf4eP iAModpSvCPTMIv5olne++9TQM9LeOMczlORoZ9KOo89ZiCkDd1SHqJWTZetx895rMY4M /ofCVzweAv/f2D+spUiIUcCcleS6iOxolh/cBGDcjOILvOY7Ja9U2H4x73gu2NhLoG2Q +836nisTc0Pwe1KjGXtO29V/inn5NPwaoPS6fXwtJRqB4mH8dfothJ7zVqkyjdt9ulwj df7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=ZakQisLaMkcUZSMjbOhSMm43LRxwR9NlRpn3nOPPEjs=; b=Uy+xl3NaYBxxYfttfw3eSUTsdhatijNzI6P9CTUjWlWgcyuzLyUk91pE9Lv+Cb562N fxsV55IoDRRiA87X+2FybzDEtG98hqCsFchP06JzbJNJNyenBVUO/kJNVE9Mi8rLUhiw m5ZRydRjG456jcLtIPJgFDzIb1SE6shrDDAn9RfLR6mBn3R0HZagos7qIziaAfSj0IrT gyQFJbbs4JLPeyG98Qk4YVXs1guFmow0V3u2mP1cdoreQaU368HSyxdWLxNxJqvmTHqk BQmCa33tLKrHt0PD5WQNcwjPFiFNV6K9ozCy75eMy/hHW9TCB3EqZx20VSxC/yfKuUAx 4T6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tA5sL9Lx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ca24si1225150edb.492.2021.01.12.05.30.52; Tue, 12 Jan 2021 05:31:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tA5sL9Lx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730689AbhALN3I (ORCPT + 99 others); Tue, 12 Jan 2021 08:29:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:40892 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728100AbhALN3H (ORCPT ); Tue, 12 Jan 2021 08:29:07 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 06EF922E03; Tue, 12 Jan 2021 13:28:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610458106; bh=BgmXOmhB4SO2UGr1hcUsI1jWHWhAohBufvGcpIqsYlc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tA5sL9LxMoOr4UX5ETiwJ11S1yUVLKDtVP6PygWPVz18jfURemuvCenp7Df0JdFUN 9nhIV6NzqpAF7tM8nV/Zw3x3UNmtgOLBDGH1IgS96JbPClwcqoQBu24qwrqr3V02QO +i4udaOb+TRTB/PBfPmiyb3/K0H7euC/VZoPdrUmj2PsMkxjHWkl1kIgtgLOa4WHVI ETSwZK5IYQ9ASMvRq0NONKfekizdz8Gawi1kscOKAitAIPCaS6M8x2MwHAvTTRzpP4 bCplgnZotPS6PL/YSSf51/3fyugTAT1BMMgc4uu5lCRzRsnAn7y3Azyu9xo2KfPbdz lQq2ov2bDI9aQ== Date: Tue, 12 Jan 2021 13:28:22 +0000 From: Will Deacon To: Alex Shi Cc: Peter Zijlstra , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH] locking/rtmutex: add missed kernel-doc markup Message-ID: <20210112132821.GA9087@willie-the-truck> References: <1605257895-5536-1-git-send-email-alex.shi@linux.alibaba.com> <1605257895-5536-2-git-send-email-alex.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1605257895-5536-2-git-send-email-alex.shi@linux.alibaba.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 13, 2020 at 04:58:11PM +0800, Alex Shi wrote: > To fix the following issues: > kernel/locking/rtmutex.c:1612: warning: Function parameter or member > 'lock' not described in '__rt_mutex_futex_unlock' > kernel/locking/rtmutex.c:1612: warning: Function parameter or member > 'wake_q' not described in '__rt_mutex_futex_unlock' > kernel/locking/rtmutex.c:1675: warning: Function parameter or member > 'name' not described in '__rt_mutex_init' > kernel/locking/rtmutex.c:1675: warning: Function parameter or member > 'key' not described in '__rt_mutex_init' > > Signed-off-by: Alex Shi > Cc: Peter Zijlstra > Cc: Ingo Molnar > Cc: Will Deacon > Cc: linux-kernel@vger.kernel.org > --- > kernel/locking/rtmutex.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/kernel/locking/rtmutex.c b/kernel/locking/rtmutex.c > index cfdd5b93264d..50fa521fe767 100644 > --- a/kernel/locking/rtmutex.c > +++ b/kernel/locking/rtmutex.c > @@ -1604,8 +1604,11 @@ void __sched rt_mutex_unlock(struct rt_mutex *lock) > EXPORT_SYMBOL_GPL(rt_mutex_unlock); > > /** > - * Futex variant, that since futex variants do not use the fast-path, can be > - * simple and will not need to retry. > + * __rt_mutex_futex_unlock - Futex variant, that since futex variants > + * do not use the fast-path, can be simple and will not need to retry. > + * > + * @lock: the rt_mutex to be unlocked > + * @wake_q: wake queue head from which get the next lock waiter missing word: from which *to* get With that fixed, Acked-by: Will Deacon Will