Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 12 Jan 2021 14:46:28 +0100
Message-ID: <s5hy2gyqnd7.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Thierry Reding <thierry.reding@gmail.com>
Cc:     Peter Geis <pgwipeout@gmail.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Peter De Schrijver <pdeschrijver@nvidia.com>,
        Prashant Gaikwad <pgaikwad@nvidia.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Sameer Pujar <spujar@nvidia.com>,
        Mohan Kumar <mkumard@nvidia.com>, linux-clk@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
        alsa-devel@alsa-project.org
Subject: Re: [PATCH v2 0/2] fix tegra-hda on tegra30 devices
In-Reply-To: <X/2ddbamUzXECZDT@ulmo>
References: <20210108135913.2421585-1-pgwipeout@gmail.com>
        <s5hv9c2sgxd.wl-tiwai@suse.de>
        <X/2ddbamUzXECZDT@ulmo>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Tue, 12 Jan 2021 14:00:37 +0100,
Thierry Reding wrote:
> 
> On Tue, Jan 12, 2021 at 09:22:38AM +0100, Takashi Iwai wrote:
> > On Fri, 08 Jan 2021 14:59:11 +0100,
> > Peter Geis wrote:
> > > 
> > > The following patches fix tegra-hda on legacy tegra devices.
> > > Two issues were discovered preventing tegra-hda from functioning:
> > > -The hda clocks on tegra30 were assigned to clk_m and running at too low
> > > of a rate to function.
> > > -The tegra-hda encounters an input/output error when opening a stream.
> > > 
> > > Since the only mainline device that used tegra-hda until recently was the
> > > t124, it is unknown exactly when this was broken. Fortunately a recent
> > > patch was submitted that fixed the issue only on t194 devices. We can
> > > apply it to the tegra30-hda device to resolve the issue across the board.
> > > Note that downstream devices used the spdif device instead of hda for hdmi
> > > audio. The spdif device lacks a driver on mainline.
> > > 
> > > -Checkpatch seems to have issues finding [1], but git show has no issue.
> > > [1] commit 60019d8c650d ("ALSA: hda/tegra: workaround playback failure on
> > > Tegra194")
> > > 
> > > Changelog:
> > > 
> > > v2:
> > > -Added ack and reviewed-by from Jon
> > > -Updated fix to apply to tegra30-hda vice universally (Thanks Jon)
> > > -Updated commit to include comments from hardware team (Thanks Sameer)
> > > -Cleaned up commit messages
> > > 
> > > Peter Geis (2):
> > >   clk: tegra30: Add hda clock default rates to clock driver
> > >   ALSA: hda/tegra: fix tegra-hda on tegra30 soc
> > 
> > Shall I apply both patches via sound git tree?
> > 
> > Or, if you want to take through clk tree, let me know.  In that case,
> > feel free to take my ack:
> > Acked-by: Takashi Iwai <tiwai@suse.de>
> 
> There doesn't seem to be a build-time (or even runtime) dependency
> between the two patches and they fix two independent issues, so they
> could also go in separately.

Yes.  OTOH, it's better to be applied in a shot when you look back at
the changes later.

> I'm fine either way. From a Tegra perspective, the Tegra30 clock driver
> is very low activity, so I don't expect any conflicts with between this
> and some other patches that might go in through the clock tree.

OK, then I queued both patches now to for-linus branch in sound tree.


Thanks!

Takashi