From: Arnd Bergmann <arnd@arndb.de>
To: "Misha Tomushev" <misha@fabric7.com>
Subject: Re: [PATCH] VIOC: New Network Device Driver
Date: Mon, 11 Sep 2006 21:15:52 +0200
User-Agent: KMail/1.9.1
Cc: jgarzik@pobox.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <003c01c6d5cb$e00fd850$7501a8c0@ZINLAPTOP>
In-Reply-To: <003c01c6d5cb$e00fd850$7501a8c0@ZINLAPTOP>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200609112115.53520.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1062
Lines: 22

On Monday 11 September 2006 19:58, Misha Tomushev wrote:
> The descriptor clean-up does not contribute anything to the performance
> of the driver, it just replenishes the memory pools. It almost does not
> need interrupts. Why would we want to add more cycles to the receive
> logic, when driver is doing useful work for something that can run
> almost at any time?

It can run at almost any time, just not in the interrupt context,
where it needs to schedule the tx softirq first.

Also, the number of tx interrupts you get is a tradeoff between
causing overhead of calling the interrupt handler and stalling
sockets that are waiting for space to become free after transmission.
By using ->poll for it, you can avoid tx interrupts completely
most of the time and free skbs immediately when data comes in.

	Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/