Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     Li Feng <fengli@smartx.com>
Cc:     Jens Axboe <axboe@kernel.dk>,
        linux-block@vger.kernel.org (open list:BLOCK LAYER),
        linux-kernel@vger.kernel.org (open list), lifeng1519@gmail.com
Subject: Re: [PATCH v2] blk: avoid divide-by-zero with zero granularity
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1v9c25bm1.fsf@ca-mkp.ca.oracle.com>
References: <20210112152951.154024-1-fengli@smartx.com>
        <20210112155502.426331-1-fengli@smartx.com>
Date:   Tue, 12 Jan 2021 12:10:05 -0500
In-Reply-To: <20210112155502.426331-1-fengli@smartx.com> (Li Feng's message of
        "Tue, 12 Jan 2021 23:55:02 +0800")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from ca-mkp.ca.oracle.com (138.3.200.58) by SJ0PR13CA0152.namprd13.prod.outlook.com (2603:10b6:a03:2c7::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.2 via Frontend Transport; Tue, 12 Jan 2021 17:10:08 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 836c528a-5843-4467-b4ca-08d8b71cea31
X-MS-TrafficTypeDiagnostic: PH0PR10MB4502:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <PH0PR10MB4502532A86B3C69D755CF0F88EAA0@PH0PR10MB4502.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4502;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: GD3CQpmld+tduX/9ELrUGraqCXW8CcTMjQ5OLELyQuIcpWJfLHx0t2Nq38N8dymI15veQRbkPjADFgidM9cpXxpoWYLNmPkEfjq3h3QhfiCTiY7Gavd5PdIJ2W2X7wDrjFhegg7tlqx+KJAE0nb9eOblAjxDs6x2vxROzchq/+LVEaEwYINT2w5i+LCbiaw6YvL92gmHQnaSG1p3SUPtnjm6+UzAIOc89qleBUscKTaYxwnGdFQDLhU3Gj0nbMaNESBgPH+PTJD2ff2wNhsfbCuWqtvOGZMp6CrECNu+xXnyaNYqUWzz6TO4+Y3McQ4rF1+FTBNsHkHBRDQDCmwZaApItVvkNyIiUZojd7Mr8g4ULaRV0Rv+mKAKO74dygD33i6dSuLTSyjETC/RIWFQpQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(396003)(346002)(376002)(366004)(39840400004)(558084003)(36916002)(316002)(6666004)(6916009)(478600001)(55016002)(7696005)(16526019)(52116002)(66476007)(66946007)(8936002)(4326008)(26005)(186003)(8676002)(956004)(66556008)(86362001)(2906002)(5660300002)(83380400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?G2OoxDL+TPg0uluunj0pTx7QohY/t0ycktpR6dGij+G9u0GIT+NyT+PnfoiG?=
 =?us-ascii?Q?KxjWZyzUPoz/fluveHcWm4s8CXKKrt1RpaIGPbi1ySsZ+rauQOmmdYBmmzSk?=
 =?us-ascii?Q?z9SXpUTFRiFD57h7BkleHn5Dmga2HExmVWvczWjGK0RQzbpVpiVQ45wSbC03?=
 =?us-ascii?Q?mP4n3gjWWsN5ES91TgXXu+gMmjlCS1nfcgV/kCK08Oif6lVkERwCvonS867N?=
 =?us-ascii?Q?hU4CE7IBrmWE0Y8BSShDd4tEwTlAIZGJ1a2hdVreWdaiNP+DYmEWM152qZQt?=
 =?us-ascii?Q?h6UhNt8cGFzuFkBLO6UKkB9QY6BbN8fHr0Ar75ZAsXG7SdnlASenO19Obcum?=
 =?us-ascii?Q?9+yrxhg6lYj7ixh79aiok2pWvMZWkyyaEKrY9jupInQUHuRTNuIo0See1CfZ?=
 =?us-ascii?Q?uJ0vMncOyyTqiR/3NLqfxYvCGdon9+JvcHIfi5VJI1kFEle4Nki3Wpj/THYO?=
 =?us-ascii?Q?O1f6y09/3NSlmQ3qxevEYTMJ60me/KNkU9ftl62jGC517es1vr1VBvlhivzE?=
 =?us-ascii?Q?qnn753rqFlqlbN6z4U8LSARXoViLdjJSd7p8s528+76t2qBTZx1VWIDJgz0X?=
 =?us-ascii?Q?oxKqgxALtQ4Uq4u5AWNL0N1LWtpVkqggfc7Vxfj8u7trpGu+q156d4Jh5ab3?=
 =?us-ascii?Q?yOrL8ioMUR0PoRapUC/+bxsSTIGvuuCSbUlxEDHjGSFNubELnFdoBDTUlKnm?=
 =?us-ascii?Q?lL2NNvnid7NpLW2kZDDEN6DZNxd/xBW54KA65l9kjj+zUYajx7/UjIE84hUc?=
 =?us-ascii?Q?JL7YlorBx4KMaqHivLNN0yOgNgIkECrp00AaTu0ieJ4rftf0v3RLAPy/hCOG?=
 =?us-ascii?Q?ND4cdomgDuXDSlxDc1cPz4YTAyDqGshmWGSnhbprRGFz1GrKTMyaUX59UjVc?=
 =?us-ascii?Q?eGw/ZQubm5N94am+TXQspvaKSc6Nb1j+jJyPGOEaEDIRQueLV5pqC1v7z/Rf?=
 =?us-ascii?Q?qM71JUVPowvNJ6KlK6SNAP5wrS76RYekgNX78IGbwxY=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2021 17:10:08.7296
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-Network-Message-Id: 836c528a-5843-4467-b4ca-08d8b71cea31
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ap6DhSQNZ4M2vkPepR9zIAifEeSt4ShE+5OKdYGWnmSRDxSxqClLI3CdAJYRamqKyUkvjt2KpMBCwkLPLViFL3nBMpaYJoKCLa9lQV0iAc4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4502
X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9862 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 malwarescore=0
 suspectscore=0 adultscore=0 spamscore=0 mlxlogscore=889 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2101120100
X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9862 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0
 lowpriorityscore=0 bulkscore=0 priorityscore=1501 malwarescore=0
 clxscore=1011 impostorscore=0 spamscore=0 mlxscore=0 suspectscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2009150000 definitions=main-2101120100
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Li,

> If the physical_block_size and io_min is less than a sector,

That's not supposed to happen. What device/driver is this?

-- 
Martin K. Petersen	Oracle Linux Engineering