Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] i2c: tegra: Create i2c_writesl_vi() to use with VI I2C
 for filling TX FIFO
To:     Sowjanya Komatineni <skomatineni@nvidia.com>,
        thierry.reding@gmail.com, jonathanh@nvidia.com, wsa@the-dreams.de
Cc:     linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-i2c@vger.kernel.org
References: <1610424379-23653-1-git-send-email-skomatineni@nvidia.com>
 <1610424379-23653-2-git-send-email-skomatineni@nvidia.com>
 <ae886d28-ef6c-63d3-2cc7-90752ddb8b21@gmail.com>
 <c250dd2d-85fd-75a6-cdae-71e4300007de@nvidia.com>
From:   Dmitry Osipenko <digetx@gmail.com>
Message-ID: <f9a65bdd-edfa-2935-9f01-90e22e4d6246@gmail.com>
Date:   Tue, 12 Jan 2021 20:34:23 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.2
MIME-Version: 1.0
In-Reply-To: <c250dd2d-85fd-75a6-cdae-71e4300007de@nvidia.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

12.01.2021 19:57, Sowjanya Komatineni пишет:
...
>> @@ -326,6 +326,8 @@ static void i2c_writel(struct tegra_i2c_dev
>> *i2c_dev, u32 val, unsigned int reg)
>>       /* read back register to make sure that register writes
>> completed */
>>       if (reg != I2C_TX_FIFO)
>>           readl_relaxed(i2c_dev->base + tegra_i2c_reg_addr(i2c_dev,
>> reg));
>> +    else
>> +        readl_relaxed(i2c_dev->base + tegra_i2c_reg_addr(i2c_dev,
>> I2C_INT_STATUS));
>

Perhaps will be a bit better to replace this "else" with "else if
(i2c_dev->is_vi)".