Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] dmaengine: ti: k3-udma: Set rflow count for BCDMA split
 channels
To:     Vignesh Raghavendra <vigneshr@ti.com>,
        Vinod Koul <vkoul@kernel.org>
Cc:     Dan Williams <dan.j.williams@intel.com>, dmaengine@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20210112141403.30286-1-vigneshr@ti.com>
From:   =?UTF-8?Q?P=c3=a9ter_Ujfalusi?= <peter.ujfalusi@gmail.com>
Message-ID: <dc598197-6aa0-f9f9-dadc-54d1e6fb7361@gmail.com>
Date:   Tue, 12 Jan 2021 20:29:59 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.1
MIME-Version: 1.0
In-Reply-To: <20210112141403.30286-1-vigneshr@ti.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Vignesh,

On 1/12/21 4:14 PM, Vignesh Raghavendra wrote:
> BCDMA RX channels have one flow per channel, therefore set the rflow_cnt
> to rchan_cnt.
> 
> Without this patch, request for BCDMA RX channel allocation fails as
> rflow_cnt is 0 thus fails to reserve a rflow for the channel.

Good catch, thank you!

Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>

> 
> Fixes: 8844898028d4 ("dmaengine: ti: k3-udma: Add support for BCDMA channel TPL handling")
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> ---
>   drivers/dma/ti/k3-udma.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
> index 298460438bb4..a1af59d901be 100644
> --- a/drivers/dma/ti/k3-udma.c
> +++ b/drivers/dma/ti/k3-udma.c
> @@ -4305,6 +4305,7 @@ static int udma_get_mmrs(struct platform_device *pdev, struct udma_dev *ud)
>   		ud->bchan_cnt = BCDMA_CAP2_BCHAN_CNT(cap2);
>   		ud->tchan_cnt = BCDMA_CAP2_TCHAN_CNT(cap2);
>   		ud->rchan_cnt = BCDMA_CAP2_RCHAN_CNT(cap2);
> +		ud->rflow_cnt = ud->rchan_cnt;
>   		break;
>   	case DMA_TYPE_PKTDMA:
>   		cap4 = udma_read(ud->mmrs[MMR_GCFG], 0x30);
> 

-- 
Péter