Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 12 Jan 2021 01:09:23 +0100
From:   Borislav Petkov <bp@alien8.de>
To:     Krzysztof Mazur <krzysiek@podlesie.net>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] x86/lib: don't use MMX before FPU initialization
Message-ID: <20210112000923.GK25645@zn.tnic>
References: <20201228160631.32732-1-krzysiek@podlesie.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20201228160631.32732-1-krzysiek@podlesie.net>
Precedence: bulk

On Mon, Dec 28, 2020 at 05:06:31PM +0100, Krzysztof Mazur wrote:
> When enabled, the MMX 3DNow! optimized memcpy() is used very early,
> even before FPU is initialized. It worked fine, but commit
> 7ad816762f9bf89e940e618ea40c43138b479e10 ("x86/fpu: Reset MXCSR
> to default in kernel_fpu_begin()") broke that. After that commit
> the kernel crashes just after "Booting the kernel." message.

Have you figured out in the meantime what exactly is causing the
breakage?

Does it boot if you comment out

+       if (boot_cpu_has(X86_FEATURE_FPU))
+               asm volatile ("fninit");

in kernel_fpu_begin()?

I'm guessing K7 doesn't have X86_FEATURE_XMM so the LDMXCSR won't
matter...

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette