Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp3458727pxb; Tue, 12 Jan 2021 15:34:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJw4uJspybZ1Pjsoeh0xeIZaYbwjcTpizBcXffBFdQGlyXLsU7EO4vZtVKP2PzXCGj6s8l/9 X-Received: by 2002:a17:906:a008:: with SMTP id p8mr827605ejy.117.1610494481707; Tue, 12 Jan 2021 15:34:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610494481; cv=none; d=google.com; s=arc-20160816; b=O5pJMBeqiQpONo5pe4bPUflLpqf2U+v3TCpk1kxGLOC2dM7H0XjEPmHUeRJp2ZOVph ON1FfBZV/9aErEoQkfgHiGw1YcYwFYSv+iPgKCUx+NHVtSNN6wMbLbwcli9C2vAUtSBT S7v8IZe/IciMmq8ZLdfnSzBCpCrhsixD2A/eiu9mNAiqy62a2O6VoRrmfd3Dqj6HFmml FMNgvg4ktW/PPwccc291gylpfczyHPFoqwYAq1tjIyOVYgq5koPONE+05GGHIrXig+d9 86gV5B9U/bJbag2S3wDPFCy8NbqchANSvukzH4NvR0Lzca4zonQ6c/DnXJK0WUS0yadM fQqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=rF1rxhAXoo+MJQwc2G63IVdCOVAGj6FiVkcoBMgNueY=; b=I47ZpYCLurmW9PV0GoIZDf2cOy7BiGSaldBNi4/74VKvOSno0bHBQffIGWbtLaA8On ka0rriJxHZGfKzMVCasGMJx3r3r2B/rz9QdiPcpX1UrQrywZp3ayhbXIpSoIeUuE37AU Dmqg68EbXjCH+w4/gEcS2vivmA+ZTPteKSJilInaS0qa0WmvilXxZRU3Xk+HBxvuG5iP f5Dq2MQ1ZPscVo2NQ+gUVfJUwyqdFN9W/RiM8B553OYP3agd8MQ/H+WrGeIAFNeLP1O+ HSe1oz95/UeG6hmHJGYWdZoEVXWTXZhBGNo5foaFqmyYFOn0Pc9utHKrO/60dApOZtzi l+CQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l13si83730ejr.754.2021.01.12.15.34.18; Tue, 12 Jan 2021 15:34:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405817AbhALJCL (ORCPT + 99 others); Tue, 12 Jan 2021 04:02:11 -0500 Received: from relmlor2.renesas.com ([210.160.252.172]:18782 "EHLO relmlie6.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2405738AbhALJBy (ORCPT ); Tue, 12 Jan 2021 04:01:54 -0500 X-IronPort-AV: E=Sophos;i="5.79,340,1602514800"; d="scan'208";a="68514080" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie6.idc.renesas.com with ESMTP; 12 Jan 2021 18:01:19 +0900 Received: from localhost.localdomain (unknown [10.166.252.89]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id 651DC40062D6; Tue, 12 Jan 2021 18:01:19 +0900 (JST) From: Yoshihiro Shimoda To: marek.vasut+renesas@gmail.com, lee.jones@linaro.org, matti.vaittinen@fi.rohmeurope.com, lgirdwood@gmail.com, broonie@kernel.org, linus.walleij@linaro.org, bgolaszewski@baylibre.com Cc: khiem.nguyen.xt@renesas.com, linux-power@fi.rohmeurope.com, linux-gpio@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Yoshihiro Shimoda Subject: [PATCH v9 10/12] mfd: bd9571mwv: Use devm_regmap_add_irq_chip() Date: Tue, 12 Jan 2021 18:01:05 +0900 Message-Id: <1610442067-7446-11-git-send-email-yoshihiro.shimoda.uh@renesas.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1610442067-7446-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> References: <1610442067-7446-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use devm_regmap_add_irq_chip() to simplify the code. Signed-off-by: Yoshihiro Shimoda Acked-for-MFD-by: Lee Jones Reviewed-by: Matti Vaittinen Reviewed-by: Geert Uytterhoeven --- drivers/mfd/bd9571mwv.c | 27 ++++++--------------------- 1 file changed, 6 insertions(+), 21 deletions(-) diff --git a/drivers/mfd/bd9571mwv.c b/drivers/mfd/bd9571mwv.c index e68c3fa..49e968e 100644 --- a/drivers/mfd/bd9571mwv.c +++ b/drivers/mfd/bd9571mwv.c @@ -170,31 +170,17 @@ static int bd9571mwv_probe(struct i2c_client *client, if (ret) return ret; - ret = regmap_add_irq_chip(bd->regmap, bd->irq, IRQF_ONESHOT, 0, - &bd9571mwv_irq_chip, &bd->irq_data); + ret = devm_regmap_add_irq_chip(bd->dev, bd->regmap, bd->irq, + IRQF_ONESHOT, 0, &bd9571mwv_irq_chip, + &bd->irq_data); if (ret) { dev_err(bd->dev, "Failed to register IRQ chip\n"); return ret; } - ret = devm_mfd_add_devices(bd->dev, PLATFORM_DEVID_AUTO, - bd9571mwv_cells, ARRAY_SIZE(bd9571mwv_cells), - NULL, 0, regmap_irq_get_domain(bd->irq_data)); - if (ret) { - regmap_del_irq_chip(bd->irq, bd->irq_data); - return ret; - } - - return 0; -} - -static int bd9571mwv_remove(struct i2c_client *client) -{ - struct bd9571mwv *bd = i2c_get_clientdata(client); - - regmap_del_irq_chip(bd->irq, bd->irq_data); - - return 0; + return devm_mfd_add_devices(bd->dev, PLATFORM_DEVID_AUTO, + bd9571mwv_cells, ARRAY_SIZE(bd9571mwv_cells), + NULL, 0, regmap_irq_get_domain(bd->irq_data)); } static const struct of_device_id bd9571mwv_of_match_table[] = { @@ -215,7 +201,6 @@ static struct i2c_driver bd9571mwv_driver = { .of_match_table = bd9571mwv_of_match_table, }, .probe = bd9571mwv_probe, - .remove = bd9571mwv_remove, .id_table = bd9571mwv_id_table, }; module_i2c_driver(bd9571mwv_driver); -- 2.7.4