Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/9] media: mtk-mdp: Do not zero reserved fields
To:     Ricardo Ribalda <ribalda@chromium.org>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Matthias Brugger <matthias.bgg@gmail.com>
References: <20210111145445.28854-1-ribalda@chromium.org>
 <20210111145445.28854-3-ribalda@chromium.org>
Reply-To: kieran.bingham+renesas@ideasonboard.com
From:   Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Organization: Ideas on Board
Message-ID: <d7b39657-ef60-b388-042c-4db76ad5cde6@ideasonboard.com>
Date:   Tue, 12 Jan 2021 12:01:05 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20210111145445.28854-3-ribalda@chromium.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Ricardo,

On 11/01/2021 14:54, Ricardo Ribalda wrote:
> Core code already clears reserved fields of struct
> v4l2_pix_format_mplane, check: 4e1e0eb0e074 ("media: v4l2-ioctl: Zero
> v4l2_plane_pix_format reserved fields").
> 
> Cc: Matthias Brugger <matthias.bgg@gmail.com>
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

> ---
>  drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c b/drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c
> index 724c7333b6e5..ace4528cdc5e 100644
> --- a/drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c
> +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c
> @@ -199,7 +199,6 @@ static const struct mtk_mdp_fmt *mtk_mdp_try_fmt_mplane(struct mtk_mdp_ctx *ctx,
>  		pix_mp->ycbcr_enc = ctx->ycbcr_enc;
>  		pix_mp->quantization = ctx->quant;
>  	}
> -	memset(pix_mp->reserved, 0, sizeof(pix_mp->reserved));
>  
>  	max_w = variant->pix_max->target_rot_dis_w;
>  	max_h = variant->pix_max->target_rot_dis_h;
> @@ -247,8 +246,6 @@ static const struct mtk_mdp_fmt *mtk_mdp_try_fmt_mplane(struct mtk_mdp_ctx *ctx,
>  		pix_mp->plane_fmt[i].bytesperline = bpl;
>  		if (pix_mp->plane_fmt[i].sizeimage < sizeimage)
>  			pix_mp->plane_fmt[i].sizeimage = sizeimage;
> -		memset(pix_mp->plane_fmt[i].reserved, 0,
> -		       sizeof(pix_mp->plane_fmt[i].reserved));
>  		mtk_mdp_dbg(2, "[%d] p%d, bpl:%d, sizeimage:%u (%u)", ctx->id,
>  			    i, bpl, pix_mp->plane_fmt[i].sizeimage, sizeimage);
>  	}
>