Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
References: <20210104192602.10131-1-nramas@linux.microsoft.com>
 <20210112144248.GA256955@robh.at.kernel.org>
 <601825013d67584b0d2de7a973b806ec3cbc05ca.camel@linux.ibm.com>
User-agent: mu4e 1.4.10; emacs 27.1
From:   Thiago Jung Bauermann <bauerman@linux.ibm.com>
To:     Mimi Zohar <zohar@linux.ibm.com>
Cc:     Rob Herring <robh@kernel.org>,
        Lakshmi Ramasubramanian <nramas@linux.microsoft.com>,
        takahiro.akashi@linaro.org, gregkh@linuxfoundation.org,
        will@kernel.org, catalin.marinas@arm.com, mpe@ellerman.id.au,
        james.morse@arm.com, sashal@kernel.org, benh@kernel.crashing.org,
        paulus@samba.org, frowand.list@gmail.com,
        vincenzo.frascino@arm.com, mark.rutland@arm.com,
        dmitry.kasatkin@gmail.com, jmorris@namei.org, serge@hallyn.com,
        pasha.tatashin@soleen.com, allison@lohutok.net,
        masahiroy@kernel.org, bhsharma@redhat.com, mbrugger@suse.com,
        hsinyi@chromium.org, tao.li@vivo.com, christophe.leroy@c-s.fr,
        prsriva@linux.microsoft.com, balajib@linux.microsoft.com,
        linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v14 0/6] Carry forward IMA measurement log on kexec on
 ARM64
In-reply-to: <601825013d67584b0d2de7a973b806ec3cbc05ca.camel@linux.ibm.com>
Date:   Tue, 12 Jan 2021 15:45:08 -0300
Message-ID: <87eeiqro3v.fsf@manicouagan.localdomain>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk


Mimi Zohar <zohar@linux.ibm.com> writes:

> On Tue, 2021-01-12 at 08:42 -0600, Rob Herring wrote:
>> On Mon, Jan 04, 2021 at 11:25:56AM -0800, Lakshmi Ramasubramanian wrote:
>> > On kexec file load Integrity Measurement Architecture (IMA) subsystem
>> > may verify the IMA signature of the kernel and initramfs, and measure
>> > it. The command line parameters passed to the kernel in the kexec call
>> > may also be measured by IMA. A remote attestation service can verify
>> > a TPM quote based on the TPM event log, the IMA measurement list, and
>> > the TPM PCR data. This can be achieved only if the IMA measurement log
>> > is carried over from the current kernel to the next kernel across
>> > the kexec call.
>> > 
>> > powerpc already supports carrying forward the IMA measurement log on
>> > kexec. This patch set adds support for carrying forward the IMA
>> > measurement log on kexec on ARM64. 
>> > 
>> > This patch set moves the platform independent code defined for powerpc
>> > such that it can be reused for other platforms as well. A chosen node
>> > "linux,ima-kexec-buffer" is added to the DTB for ARM64 to hold
>> > the address and the size of the memory reserved to carry
>> > the IMA measurement log.
>> > 
>> > This patch set has been tested for ARM64 platform using QEMU.
>> > I would like help from the community for testing this change on powerpc.
>> > Thanks.
>> > 
>> > This patch set is based on
>> > commit a29a64445089 ("powerpc: Use common of_kexec_setup_new_fdt()")
>> > in https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git
>> > "dt/kexec" branch.
>> 
>> This all looks good to me. I'd suggest you send the above patches out as 
>> part of this series because I don't plan to do so.
>> 
>> I would like to also resolve the vmalloc vs. kmalloc difference for 
>> allocating the FDT. Then we can further consolidate the DT kexec code.
>> 
>> It all needs some acks from arm64 and powerpc maintainers. As far as 
>> merging, I think via the integrity tree makes the most sense.
>
> Thanks, Rob.  Lakshmi,  please update Rob's patches to include patch
> descriptions before re-posting.

Also please update the powerpc mailing list address to
linuxppc-dev@lists.ozlabs.org

-- 
Thiago Jung Bauermann
IBM Linux Technology Center