Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp26151pxb; Tue, 12 Jan 2021 18:55:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJxc2Yl3BaYaCYe2bhKhLnMPQeJGzAPaFtE6qNvn5AKjEFRt9o9N+zLM+mcSnc3abCke9BYQ X-Received: by 2002:a17:906:780c:: with SMTP id u12mr1279046ejm.125.1610506533995; Tue, 12 Jan 2021 18:55:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610506533; cv=none; d=google.com; s=arc-20160816; b=BOGxWed26U/nF9clm9+viJcJiTyUSwwa5+SFR7L8VkOugbdCej/YmmD746bDdwrA1T zGQHEsKC6/kI0cu0zRzksGmHIzrOZbe0VJ59zp3XXwlrryLgA1QTsubZj5T+G+mqdcT2 Q7K0cgu+61llRi99+b3EE763QWSB6zDzvEw89sZpesjkJfOY4OL0WjHGCncuyA7Ahj/f YUprlLhar16Z0ovp2ZA5XNJlpeF57gRxFottwjO81aqjfY423xSjNhCm9SSIEvHPz48Q d3587TpgJbINR+idUmvfwwzxVuL/zWSl3OLpdoZGhQ36IeIo4FFNLngCIYe7TJut4z2Q ee2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=fMOsJ+yCzpE8j0c8U4hOEUgeq7Kka7k0SjEEHdyP6UQ=; b=GGCMZVG3Gf6vIiZszYc1E6Bm1mCYAp6urSDT0t9NWrN+6MalDfCbiBNMUk1KFz+jCO TTnduG3DZtK4LcMfX9Ah5asIrHI0DIQn5tOnlHnbGTYl/sKJI1EyrLZw93j3XzFwnCZ0 HFCxhz/qVTvjMAmyAWGhKzoDyHTEdbtKTTc2QV3q9+8PltNtCb0I0zLNzYgCQ+8zLbJm mrhRZDotkEXM3WRemcBr+C64F4pMIehCxi2sPQrCnz/seWlI3bk5ke5ePYGMPTa6/E8q wsEiGL3PLKdhPHiX4Jz8A7PV3nfgEYjnViLoZ109bO7TRwx3ZnNXM6uOJ2NcHAL4TRvy nY1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=hycUmKEO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r13si309674edq.603.2021.01.12.18.55.10; Tue, 12 Jan 2021 18:55:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=hycUmKEO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393799AbhALWBQ (ORCPT + 99 others); Tue, 12 Jan 2021 17:01:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730091AbhALWBP (ORCPT ); Tue, 12 Jan 2021 17:01:15 -0500 Received: from mail-ot1-x336.google.com (mail-ot1-x336.google.com [IPv6:2607:f8b0:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BE6EC0617A2 for ; Tue, 12 Jan 2021 14:00:26 -0800 (PST) Received: by mail-ot1-x336.google.com with SMTP id i6so3851277otr.2 for ; Tue, 12 Jan 2021 14:00:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=fMOsJ+yCzpE8j0c8U4hOEUgeq7Kka7k0SjEEHdyP6UQ=; b=hycUmKEOzqPiLqOtJxG6D5fkdB9nwjQHK6Dnv6JYYzfh4UG8OCOxXjDs8opMl+BSRz Mw8hWO1kOUOzNstwMqrlvjGCvi41siDx5toR75bKx2CDBEg57yUsFqKpJwalsTBrrniO CnfbdIesuc8qxWfoJSuA7xuMWYzNYq9E42TOc88Nvu1ryorMxoPDcg9mYNQ99y20LBFT 2/dGo2jQl9PmgwqBCa0chxKlIFXZrbXslQBxehoEnZFzFYm8f2iDlfwMStQHzy0HNsOi DseN5It17TBH1hoWpX+f9KwIH5IN77khiTzgFDWi0XHrl39thCYVXr8HkYrwEg61FWxm g+UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=fMOsJ+yCzpE8j0c8U4hOEUgeq7Kka7k0SjEEHdyP6UQ=; b=l3dFxezX9FBprh7s6DiNwRBj53A17lJ4bppHOG4YBJyz+G6UzVOAYbt4VosABeZ0vZ Sx56rd9ZPINkfAG5WrkPURs5ESaCzoF53zVqLaUTi5d8PK9lvUNml9zzO7l4ePxl5sGt xskAQXG59R/CxVazcXDsaABjBfjvVWLvtnh5vXhS8l4tpQPDHaJfSKgvgwVNBYWsFpGo jNQ83EPVRQahyAnH05vlI5T/iz1o+/dnoyrqer+1OhNKtUeU8bweha6GiuO/N4hNO1eb VXk1wSkkWdOeVq8yqpYSvy9F3PtaETgRBE2QhYMoP+wyxaJzy7ltR4++v3anI/VW6w5b q9hg== X-Gm-Message-State: AOAM533u+QiXMVYzKFjtYKQ5arolquHfYwQZ0pStXDvJMv0uFXeS82/W zRPqtgtiZ+x8vXlbYEYyxJCpe+6hCldPPsr4k7E= X-Received: by 2002:a05:6830:1b7b:: with SMTP id d27mr1060690ote.132.1610488825915; Tue, 12 Jan 2021 14:00:25 -0800 (PST) MIME-Version: 1.0 References: <20210111191926.3688443-1-lee.jones@linaro.org> <20210111191926.3688443-5-lee.jones@linaro.org> In-Reply-To: <20210111191926.3688443-5-lee.jones@linaro.org> From: Alex Deucher Date: Tue, 12 Jan 2021 17:00:15 -0500 Message-ID: Subject: Re: [PATCH 04/40] drm/amd/display/dc/dce/dce_opp: Demote non-compliant kernel-doc headers To: Lee Jones Cc: Leo Li , Mauro Rossi , LKML , amd-gfx list , David Airlie , Maling list - DRI developers , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 11, 2021 at 2:19 PM Lee Jones wrote: > > Fixes the following W=3D1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_opp.c:109: warning: Fun= ction parameter or member 'opp110' not described in 'set_truncation' > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_opp.c:109: warning: Fun= ction parameter or member 'params' not described in 'set_truncation' > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_opp.c:154: warning: Fun= ction parameter or member 'opp110' not described in 'dce60_set_truncation' > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_opp.c:154: warning: Fun= ction parameter or member 'params' not described in 'dce60_set_truncation' > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_opp.c:204: warning: Fun= ction parameter or member 'opp110' not described in 'set_spatial_dither' > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_opp.c:204: warning: Fun= ction parameter or member 'params' not described in 'set_spatial_dither' > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_opp.c:308: warning: Fun= ction parameter or member 'opp110' not described in 'set_temporal_dither' > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_opp.c:308: warning: Fun= ction parameter or member 'params' not described in 'set_temporal_dither' > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_opp.c:370: warning: Fun= ction parameter or member 'opp110' not described in 'dce110_opp_set_clampin= g' > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_opp.c:370: warning: Fun= ction parameter or member 'params' not described in 'dce110_opp_set_clampin= g' > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_opp.c:430: warning: Fun= ction parameter or member 'opp110' not described in 'dce60_opp_set_clamping= ' > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_opp.c:430: warning: Fun= ction parameter or member 'params' not described in 'dce60_opp_set_clamping= ' > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_opp.c:478: warning: Fun= ction parameter or member 'opp110' not described in 'set_pixel_encoding' > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_opp.c:478: warning: Fun= ction parameter or member 'params' not described in 'set_pixel_encoding' > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_opp.c:514: warning: Fun= ction parameter or member 'opp110' not described in 'dce60_set_pixel_encodi= ng' > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_opp.c:514: warning: Fun= ction parameter or member 'params' not described in 'dce60_set_pixel_encodi= ng' > > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Cc: "Christian K=C3=B6nig" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Mauro Rossi > Cc: Lee Jones > Cc: amd-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/display/dc/dce/dce_opp.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_opp.c b/drivers/gpu/d= rm/amd/display/dc/dce/dce_opp.c > index 2bf8f5a2e0c22..4600231da6cbb 100644 > --- a/drivers/gpu/drm/amd/display/dc/dce/dce_opp.c > +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_opp.c > @@ -97,7 +97,7 @@ enum { > > > > -/** > +/* > * set_truncation > * 1) set truncation depth: 0 for 18 bpp or 1 for 24 bpp > * 2) enable truncation > @@ -142,7 +142,7 @@ static void set_truncation( > } > > #if defined(CONFIG_DRM_AMD_DC_SI) > -/** > +/* > * dce60_set_truncation > * 1) set truncation depth: 0 for 18 bpp or 1 for 24 bpp > * 2) enable truncation > @@ -183,7 +183,7 @@ static void dce60_set_truncation( > } > #endif > > -/** > +/* > * set_spatial_dither > * 1) set spatial dithering mode: pattern of seed > * 2) set spatial dithering depth: 0 for 18bpp or 1 for 24bpp > @@ -291,7 +291,7 @@ static void set_spatial_dither( > FMT_SPATIAL_DITHER_EN, 1); > } > > -/** > +/* > * SetTemporalDither (Frame Modulation) > * 1) set temporal dither depth > * 2) select pattern: from hard-coded pattern or programmable patter= n > @@ -355,7 +355,7 @@ static void set_temporal_dither( > FMT_TEMPORAL_DITHER_EN, 1); > } > > -/** > +/* > * Set Clamping > * 1) Set clamping format based on bpc - 0 for 6bpc (No clamping) > * 1 for 8 bpc > @@ -415,7 +415,7 @@ void dce110_opp_set_clamping( > } > > #if defined(CONFIG_DRM_AMD_DC_SI) > -/** > +/* > * Set Clamping for DCE6 parts > * 1) Set clamping format based on bpc - 0 for 6bpc (No clamping) > * 1 for 8 bpc > @@ -465,7 +465,7 @@ static void dce60_opp_set_clamping( > } > #endif > > -/** > +/* > * set_pixel_encoding > * > * Set Pixel Encoding > @@ -501,7 +501,7 @@ static void set_pixel_encoding( > } > > #if defined(CONFIG_DRM_AMD_DC_SI) > -/** > +/* > * dce60_set_pixel_encoding > * DCE6 has no FMT_SUBSAMPLING_{MODE,ORDER} bits in FMT_CONTROL reg > * Set Pixel Encoding > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel