Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210111191926.3688443-1-lee.jones@linaro.org> <20210111191926.3688443-9-lee.jones@linaro.org>
In-Reply-To: <20210111191926.3688443-9-lee.jones@linaro.org>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Tue, 12 Jan 2021 17:03:20 -0500
Message-ID: <CADnq5_PD_eocbg8-bfdrrF_GDOSeakZfj6dc4JGU+D9puo_beQ@mail.gmail.com>
Subject: Re: [PATCH 08/40] drm/amd/display/dc/gpio/diagnostics/hw_factory_diag:
 Fix struct declared inside parameter list error
To:     Lee Jones <lee.jones@linaro.org>
Cc:     Leo Li <sunpeng.li@amd.com>, LKML <linux-kernel@vger.kernel.org>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        David Airlie <airlied@linux.ie>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Jan 11, 2021 at 2:19 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> Fixes the following W=3D1 kernel build warning(s):
>
>  drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/diagnostics/hw_factory_dia=
g.h:30:43: warning: =E2=80=98struct hw_factory=E2=80=99 declared inside par=
ameter list will not be visible outside of this definition or declaration
>  drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/diagnostics/hw_factory_dia=
g.h:30:6: note: previous declaration of =E2=80=98dal_hw_factory_diag_fpga_i=
nit=E2=80=99 was here
>  drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/diagnostics/hw_factory_dia=
g.h:30:43: warning: =E2=80=98struct hw_factory=E2=80=99 declared inside par=
ameter list will not be visible outside of this definition or declaration
>  drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/diagnostics/hw_factory_dia=
g.h:30:6: note: previous declaration of =E2=80=98dal_hw_factory_diag_fpga_i=
nit=E2=80=99 was here
>  drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/diagnostics/hw_factory_dia=
g.h:30:43: warning: =E2=80=98struct hw_factory=E2=80=99 declared inside par=
ameter list will not be visible outside of this definition or declaration
>  drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/diagnostics/hw_factory_dia=
g.h:30:6: note: previous declaration of =E2=80=98dal_hw_factory_diag_fpga_i=
nit=E2=80=99 was here
>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian K=C3=B6nig" <christian.koenig@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Applied.  Thanks!

Alex

> ---
>  .../gpu/drm/amd/display/dc/gpio/diagnostics/hw_factory_diag.h   | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/gpio/diagnostics/hw_factory_d=
iag.h b/drivers/gpu/drm/amd/display/dc/gpio/diagnostics/hw_factory_diag.h
> index 8a74f6adb8eee..bf68eb1d9a1d2 100644
> --- a/drivers/gpu/drm/amd/display/dc/gpio/diagnostics/hw_factory_diag.h
> +++ b/drivers/gpu/drm/amd/display/dc/gpio/diagnostics/hw_factory_diag.h
> @@ -26,6 +26,8 @@
>  #ifndef __DAL_HW_FACTORY_DIAG_FPGA_H__
>  #define __DAL_HW_FACTORY_DIAG_FPGA_H__
>
> +struct hw_factory;
> +
>  /* Initialize HW factory function pointers and pin info */
>  void dal_hw_factory_diag_fpga_init(struct hw_factory *factory);
>
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel