Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210111191926.3688443-1-lee.jones@linaro.org> <20210111191926.3688443-19-lee.jones@linaro.org>
In-Reply-To: <20210111191926.3688443-19-lee.jones@linaro.org>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Tue, 12 Jan 2021 17:16:47 -0500
Message-ID: <CADnq5_PxK4Fxg2As8nZZqYW3U=Ja0jBm7sB4g+YbZNf-VK41ug@mail.gmail.com>
Subject: Re: [PATCH 18/40] drm/amd/display/dc/dce112/Makefile: Ignore
 -Woverride-init warning
To:     Lee Jones <lee.jones@linaro.org>
Cc:     Leo Li <sunpeng.li@amd.com>, LKML <linux-kernel@vger.kernel.org>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        David Airlie <airlied@linux.ie>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Jan 11, 2021 at 2:20 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> This file uses a complex abstracted set of hierarchical macros to
> setup its applicable register lists within constant structures.
> However in the case of TMDS_CNTL we wish to mark it as not applicable
> for this use-case.
>
> One method would be to de-const all of the definitions and users, then
> manually zero out TMDS_CNTL from the list.  Another would be to create
> a new set of hierarchical macros to omit TMDS_CNTL entirely.  Both
> would entail a great deal of unnecessary changes and maintenance
> burden.
>
> Fixes the following W=3D1 kernel build warning(s):
>
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:286:15=
: warning: initialized field overwritten [-Woverride-init]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:290:2:=
 note: in expansion of macro =E2=80=98stream_enc_regs=E2=80=99
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:286:15=
: note: (near initialization for =E2=80=98stream_enc_regs[0].TMDS_CNTL=E2=
=80=99)
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:290:2:=
 note: in expansion of macro =E2=80=98stream_enc_regs=E2=80=99
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:286:15=
: warning: initialized field overwritten [-Woverride-init]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:291:2:=
 note: in expansion of macro =E2=80=98stream_enc_regs=E2=80=99
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:286:15=
: note: (near initialization for =E2=80=98stream_enc_regs[1].TMDS_CNTL=E2=
=80=99)
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:291:2:=
 note: in expansion of macro =E2=80=98stream_enc_regs=E2=80=99
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:286:15=
: warning: initialized field overwritten [-Woverride-init]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:292:2:=
 note: in expansion of macro =E2=80=98stream_enc_regs=E2=80=99
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:286:15=
: note: (near initialization for =E2=80=98stream_enc_regs[2].TMDS_CNTL=E2=
=80=99)
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:292:2:=
 note: in expansion of macro =E2=80=98stream_enc_regs=E2=80=99
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:286:15=
: warning: initialized field overwritten [-Woverride-init]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:293:2:=
 note: in expansion of macro =E2=80=98stream_enc_regs=E2=80=99
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:286:15=
: note: (near initialization for =E2=80=98stream_enc_regs[3].TMDS_CNTL=E2=
=80=99)
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:293:2:=
 note: in expansion of macro =E2=80=98stream_enc_regs=E2=80=99
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:286:15=
: warning: initialized field overwritten [-Woverride-init]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:294:2:=
 note: in expansion of macro =E2=80=98stream_enc_regs=E2=80=99
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:286:15=
: note: (near initialization for =E2=80=98stream_enc_regs[4].TMDS_CNTL=E2=
=80=99)
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:294:2:=
 note: in expansion of macro =E2=80=98stream_enc_regs=E2=80=99
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:286:15=
: warning: initialized field overwritten [-Woverride-init]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:295:2:=
 note: in expansion of macro =E2=80=98stream_enc_regs=E2=80=99
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:286:15=
: note: (near initialization for =E2=80=98stream_enc_regs[5].TMDS_CNTL=E2=
=80=99)
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:295:2:=
 note: in expansion of macro =E2=80=98stream_enc_regs=E2=80=99
>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian K=C3=B6nig" <christian.koenig@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Applied.  Thanks!

Alex

> ---
>  drivers/gpu/drm/amd/display/dc/dce112/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce112/Makefile b/drivers/gpu=
/drm/amd/display/dc/dce112/Makefile
> index 8e090446d5119..9de6501702d2c 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce112/Makefile
> +++ b/drivers/gpu/drm/amd/display/dc/dce112/Makefile
> @@ -23,6 +23,8 @@
>  # Makefile for the 'controller' sub-component of DAL.
>  # It provides the control and status of HW CRTC block.
>
> +CFLAGS_$(AMDDALPATH)/dc/dce112/dce112_resource.o =3D $(call cc-disable-w=
arning, override-init)
> +
>  DCE112 =3D dce112_compressor.o dce112_hw_sequencer.o \
>  dce112_resource.o
>
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel