Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210111191926.3688443-1-lee.jones@linaro.org> <20210111191926.3688443-26-lee.jones@linaro.org>
In-Reply-To: <20210111191926.3688443-26-lee.jones@linaro.org>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Tue, 12 Jan 2021 17:26:47 -0500
Message-ID: <CADnq5_MDnYtb_zxUQfqgbDKvzHuPRdBPDj=BRBGPPme_6aa30A@mail.gmail.com>
Subject: Re: [PATCH 25/40] drm/amd/display/dc/dce120/dce120_timing_generator:
 Remove unused function 'dce120_timing_generator_get_position'
To:     Lee Jones <lee.jones@linaro.org>
Cc:     Leo Li <sunpeng.li@amd.com>, LKML <linux-kernel@vger.kernel.org>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        David Airlie <airlied@linux.ie>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Jan 11, 2021 at 2:20 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> Fixes the following W=3D1 kernel build warning(s):
>
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce120/dce120_timing_generator.=
c:602:13: warning: =E2=80=98dce120_timing_generator_get_position=E2=80=99 d=
efined but not used [-Wunused-function]
>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian K=C3=B6nig" <christian.koenig@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Applied.  Thanks!

Alex

> ---
>  .../dc/dce120/dce120_timing_generator.c       | 43 -------------------
>  1 file changed, 43 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce120/dce120_timing_generato=
r.c b/drivers/gpu/drm/amd/display/dc/dce120/dce120_timing_generator.c
> index d02ecb983c9cd..b57c466124e76 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce120/dce120_timing_generator.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce120/dce120_timing_generator.c
> @@ -589,49 +589,6 @@ static void dce120_timing_generator_set_drr(
>         }
>  }
>
> -/*
> - ***********************************************************************=
******
> - *  Function: dce120_timing_generator_get_position
> - *
> - *  @brief
> - *     Returns CRTC vertical/horizontal counters
> - *
> - *  @param [out] position
> - ***********************************************************************=
******
> - */
> -static void dce120_timing_generator_get_position(struct timing_generator=
 *tg,
> -       struct crtc_position *position)
> -{
> -       uint32_t value;
> -       struct dce110_timing_generator *tg110 =3D DCE110TG_FROM_TG(tg);
> -
> -       value =3D dm_read_reg_soc15(
> -                       tg->ctx,
> -                       mmCRTC0_CRTC_STATUS_POSITION,
> -                       tg110->offsets.crtc);
> -
> -       position->horizontal_count =3D get_reg_field_value(
> -                       value,
> -                       CRTC0_CRTC_STATUS_POSITION,
> -                       CRTC_HORZ_COUNT);
> -
> -       position->vertical_count =3D get_reg_field_value(
> -                       value,
> -                       CRTC0_CRTC_STATUS_POSITION,
> -                       CRTC_VERT_COUNT);
> -
> -       value =3D dm_read_reg_soc15(
> -                       tg->ctx,
> -                       mmCRTC0_CRTC_NOM_VERT_POSITION,
> -                       tg110->offsets.crtc);
> -
> -       position->nominal_vcount =3D get_reg_field_value(
> -                       value,
> -                       CRTC0_CRTC_NOM_VERT_POSITION,
> -                       CRTC_VERT_COUNT_NOM);
> -}
> -
> -
>  static void dce120_timing_generator_get_crtc_scanoutpos(
>         struct timing_generator *tg,
>         uint32_t *v_blank_start,
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel