Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 12 Jan 2021 15:43:26 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Praveen Chaudhary <praveen5582@gmail.com>
Cc:     davem@davemloft.net, corbet@lwn.net, kuznet@ms2.inr.ac.ru,
        yoshfuji@linux-ipv6.org, netdev@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v0 net-next 1/1] Allow user to set metric on default
 route learned via Router Advertisement.
Message-ID: <20210112154326.00f45bf1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20210112195511.13235-1-pchaudhary@linkedin.com>
References: <20210111151650.41ac7532@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
        <20210112195511.13235-1-pchaudhary@linkedin.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, 12 Jan 2021 11:55:11 -0800 Praveen Chaudhary wrote:
> Hi Jakub
>=20
> Thanks for the review,
>=20
> Sure, I will reraise the patch (again v0i, sonce no code changes) after a=
dding space before '<'.
>=20
> This patch adds lines in 'include/uapi/', that requires ABI version chang=
es for debian build. I am not sure, if we need any such changes to avoid br=
eaking allmodconfig. It will be really helpful, if you can look at the patc=
h once 'https://lkml.org/lkml/2021/1/11/1668' and suggest on this. Thanks a=
 lot again.

The code doesn't build, AFAIK it's because:

net/ipv6/ndisc.c:1322:8: error: too few arguments to function =E2=80=98rt6_=
add_dflt_router=E2=80=99