Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp49215pxb; Tue, 12 Jan 2021 19:41:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJwPpRBTh1eREUU/uLsWEpnL6/DWUXrPU3eYTnHSE5SOG8DwdaE+Hw1YaN+PGE7A7BqCZRPg X-Received: by 2002:a17:906:6608:: with SMTP id b8mr93831ejp.71.1610509308486; Tue, 12 Jan 2021 19:41:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610509308; cv=none; d=google.com; s=arc-20160816; b=05SAF6kjBhFhQYR58qG0UYpFbnVRs2mMpH6s36f9L0EfeXy5HaEgsb1v7oIWpJzIFY LaRtvteqybMK0Qneis0z9XD759QGYY3ZoC5Y4DrjZSSXMP22Eu1xD88ERzNoENQKthJ7 OszGTbWyu+OVPxpSBwmWS1zdFUeAaxDITh1OmHYUaJDCJheFggG0ifq1AkAvrkA/uHAw MZe8gEAigeOFATePDbZebhRs3DHZGOropCdxFh/5kgHYPC70Nfxm0LaT9hstPMXtZWDQ XsaCAIEG5zMEztCJKz9lf8/rCa8oRKnIntRIuws3QAPIR73a072dTIu+VBHHbP8ExxE/ 1lJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=Rf0Tm+z+YsSpYVJtqk57wny9cvw1QOGrGLU7ShJR+6w=; b=r5AZVXBmMwqJYRKuIJffbbsFLBa1BJnkDmtHbGxuIdiMuU5jwR7c/zJElLbLsrRTHt PmrU7I2+cbUKisz84lu3ixwUTUxMO1uPVs8erYmSEwQaind6rSObMpbGmvQLiIxT6e3T LC+j7i5jumaJqzj8BraGNoQwukUcX93dP5GbgjiXp/A8BwykezOokEWqVS859ekuUmKX AMgTAJdoCaa+S2qgiDkbl9cFFg81ZCqhvqz+7wFxCm4SENkp883Wt3aaCGyDsm75VsDf hwxbjUub174nnF2JH1YcbRbz2Hx4DnRNMyDglfTDz8mBNdWnXTtCNkEgPAH7O61R6JIS DaPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=vMEZSkdO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c12si373502ede.192.2021.01.12.19.41.25; Tue, 12 Jan 2021 19:41:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=vMEZSkdO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727956AbhAMCkt (ORCPT + 99 others); Tue, 12 Jan 2021 21:40:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:40528 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725843AbhAMCkt (ORCPT ); Tue, 12 Jan 2021 21:40:49 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 492B02311B; Wed, 13 Jan 2021 02:40:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610505608; bh=M6cZSkXVDkdGz/MiguWw/mBuJmE8+oCoCas/T11qQmo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=vMEZSkdOxQfpK/BRgKG3cEX6D42gZ5nNyRRCL/5A3JQ5YHqHRdzf09YoHFdbJaQKb aVlXe3zB20Ks7R5zirtU3Va4pabhOOtEBF0QWzLLIgDBA/fL6WYMrZgG09Y+FGI3wM M63koJcYqU0a7Om7oUEftiie8MgXL0miLQF06hnepRdQVXR+iOtkAmncUbHoPJDdM4 6ZKSUsfOgTFRxKJtZLCVXYZiGUSypRr+QHM3h3uruh1tjxMFQ35rzsX0DDhvGQCFoD mwtS5Agw4b+CDA2HuTLSbasoXlGrIbpX+pJecTMCkqPLRCzgRwEQvJN6+oqWga1VEL AGVS+7SEj7/Fw== Date: Tue, 12 Jan 2021 18:40:07 -0800 From: Jakub Kicinski To: Andrew Lunn , Marco Felsch Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH] net: phy: smsc: fix clk error handling Message-ID: <20210112184007.09f6fedf@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: References: <20210111085932.28680-1-m.felsch@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 11 Jan 2021 15:17:05 +0100 Andrew Lunn wrote: > On Mon, Jan 11, 2021 at 09:59:32AM +0100, Marco Felsch wrote: > > Commit bedd8d78aba3 ("net: phy: smsc: LAN8710/20: add phy refclk in > > support") added the phy clk support. The commit already checks if > > clk_get_optional() throw an error but instead of returning the error it > > ignores it. > > > > Fixes: bedd8d78aba3 ("net: phy: smsc: LAN8710/20: add phy refclk in support") > > Suggested-by: Jakub Kicinski > > Signed-off-by: Marco Felsch > > Reviewed-by: Andrew Lunn Applied, thanks!