Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 12 Jan 2021 21:16:02 -0600
From:   Rob Herring <robh@kernel.org>
To:     Adam Ford <aford173@gmail.com>
Cc:     linux-clk@vger.kernel.org, aford@beaconembedded.com,
        Luca Ceresoli <luca@lucaceresoli.net>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC 1/2] dt-bindings: clk: versaclock5:  Add load capacitance
 properties
Message-ID: <20210113031602.GA1443816@robh.at.kernel.org>
References: <20210106173900.388758-1-aford173@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210106173900.388758-1-aford173@gmail.com>
Precedence: bulk

On Wed, Jan 06, 2021 at 11:38:59AM -0600, Adam Ford wrote:
> There are two registers which can set the load capacitance for
> XTAL1 and XTAL2. These are optional registers when using an
> external crystal.  Update the bindings to support them.
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> ---
>  .../devicetree/bindings/clock/idt,versaclock5.yaml   | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> index 2ac1131fd922..e5e55ffb266e 100644
> --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> +++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> @@ -59,6 +59,18 @@ properties:
>      minItems: 1
>      maxItems: 2
>  
> +  idt,xtal1-load-femtofarads:
> +    $ref: /schemas/types.yaml#/definitions/uint32

Already has a type, so you can drop the $ref.

> +    minimum: 9000
> +    maximum: 25000
> +    description: Optional loading capacitor for XTAL1
> +
> +  idt,xtal2-load-femtofarads:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    minimum: 9000
> +    maximum: 25000
> +    description: Optional loading capacitor for XTAL2
> +
>  patternProperties:
>    "^OUT[1-4]$":
>      type: object
> -- 
> 2.25.1
>