Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp51304pxb; Tue, 12 Jan 2021 19:46:13 -0800 (PST) X-Google-Smtp-Source: ABdhPJygqJatWUu7YuBeIvUqIq5BEtkWDKi1zD94Kq4cK8QKGr/NPJNK8Gw0ScCyoxKtohCajxj2 X-Received: by 2002:a17:907:160d:: with SMTP id hb13mr79697ejc.521.1610509572960; Tue, 12 Jan 2021 19:46:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610509572; cv=none; d=google.com; s=arc-20160816; b=BCAGdC0x2CiOa9H7iIGLTxC34Abus6DRXWRnvYZZ54UqCdn4oz/GQZVHhfmeNuJ5em SGdbH2+AifBXPK9go2rs+gk9k1inrKh4cM0wec+/BkaQhC9fx6Iv096G8OFkXDTgmHsZ 00nK28K6Zx3svqOp4C9Pt2FA79EYuWw3kwWclp3hqT0d2hvgq4uW18IaOn9BBbRdBVZW eMRDCzk8pIfA0YnnAetyfWK2LGwdrc/bHoRqWZ4jvjkSVWoUKDzK/tg1jJWfvjf+rsKF DMm9zkiqeWey/b6SsRXpa2asZca05bm0WQ/eVjd1afJjHzb457CtYjhofdC2ybJXrZh+ ji3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=72xTqpfJsr2ghus6hY5mIppM3/m5OjJb/+3FmdQGaRc=; b=tEGWDlxc/iP8ljl+OocUqjlIXnuhIlQ96q5or1x9yLvdlh0EpUz3gHq2kt00fagn7/ o+QaqqUmuoCZoP356fUPSwjP0ZRhW5Z49YvMdaizzFNLZ1onnnNGUdCo7qLzVz25fdb4 izADGZJ5it0QPVMmZ7R3cEFYiMcM+4tbNr945MYv95/T41SSSfy54z/fU9nI8/JhKidV m8HIe16V5XxL+kZmC/ghbCuPNLkFlxNGZaTZdmB+4t3HkquK9fECcsA08hepJGRkxrGg yazQISvCgsb1Gj1QWzrywRT0tj6lOJinMBIT+yeVKHeuo1GGvkaricXPHjQK2WIuTqhK H5GQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i9si365232edq.66.2021.01.12.19.45.49; Tue, 12 Jan 2021 19:46:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725773AbhAMDo1 (ORCPT + 99 others); Tue, 12 Jan 2021 22:44:27 -0500 Received: from out30-42.freemail.mail.aliyun.com ([115.124.30.42]:47021 "EHLO out30-42.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725536AbhAMDo1 (ORCPT ); Tue, 12 Jan 2021 22:44:27 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R171e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01424;MF=abaci-bugfix@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0ULZwgN0_1610509396; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:abaci-bugfix@linux.alibaba.com fp:SMTPD_---0ULZwgN0_1610509396) by smtp.aliyun-inc.com(127.0.0.1); Wed, 13 Jan 2021 11:43:38 +0800 From: Yang Li To: baolin.wang7@gmail.com Cc: orsonzhai@gmail.com, linus.walleij@linaro.org, zhang.lyra@gmail.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Yang Li Subject: [PATCH v2] pinctrl: sprd: Simplify bool comparison Date: Wed, 13 Jan 2021 11:43:15 +0800 Message-Id: <1610509395-107554-1-git-send-email-abaci-bugfix@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following coccicheck warning: ./drivers/pinctrl/sprd/pinctrl-sprd.c:690:8-23: WARNING: Comparison to bool Reported-by: Abaci Robot Signed-off-by: Yang Li --- Changes in v2: - make "pinctrl: sprd:" as subject prefix drivers/pinctrl/sprd/pinctrl-sprd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/sprd/pinctrl-sprd.c b/drivers/pinctrl/sprd/pinctrl-sprd.c index 08dc193..dca7a50 100644 --- a/drivers/pinctrl/sprd/pinctrl-sprd.c +++ b/drivers/pinctrl/sprd/pinctrl-sprd.c @@ -687,7 +687,7 @@ static int sprd_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin_id, shift = INPUT_SCHMITT_SHIFT; break; case PIN_CONFIG_BIAS_PULL_UP: - if (is_sleep_config == true) { + if (is_sleep_config) { val |= SLEEP_PULL_UP; mask = SLEEP_PULL_UP_MASK; shift = SLEEP_PULL_UP_SHIFT; -- 1.8.3.1