Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210111191926.3688443-1-lee.jones@linaro.org> <20210111191926.3688443-31-lee.jones@linaro.org>
In-Reply-To: <20210111191926.3688443-31-lee.jones@linaro.org>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Tue, 12 Jan 2021 17:33:33 -0500
Message-ID: <CADnq5_OrAqWKEz1dRDectDDuRz4d+LoizAfYd4-OpOEfYADYAQ@mail.gmail.com>
Subject: Re: [PATCH 30/40] drm/amd/display/dc/dce110/dce110_timing_generator_v:
 Demote kernel-doc abuse and line up comments
To:     Lee Jones <lee.jones@linaro.org>
Cc:     Leo Li <sunpeng.li@amd.com>, LKML <linux-kernel@vger.kernel.org>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        David Airlie <airlied@linux.ie>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Jan 11, 2021 at 2:20 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> Fixes the following W=3D1 kernel build warning(s):
>
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator_=
v.c:54: warning: Function parameter or member 'tg' not described in 'dce110=
_timing_generator_v_enable_crtc'
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator_=
v.c:216: warning: Function parameter or member 'tg' not described in 'dce11=
0_timing_generator_v_wait_for_vactive'
>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian K=C3=B6nig" <christian.koenig@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Applied.  Thanks!

Alex


> ---
>  .../dc/dce110/dce110_timing_generator_v.c     | 19 +++++++++----------
>  1 file changed, 9 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_timing_generato=
r_v.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_timing_generator_v.c
> index a13a2f58944e3..c509384fff543 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_timing_generator_v.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_timing_generator_v.c
> @@ -46,17 +46,16 @@
>   *
>   ***********************************************************************=
***********/
>
> -/**
> -* Enable CRTCV
> -*/
> +/*
> + * Enable CRTCV
> + */
>
>  static bool dce110_timing_generator_v_enable_crtc(struct timing_generato=
r *tg)
>  {
>  /*
> -* Set MASTER_UPDATE_MODE to 0
> -* This is needed for DRR, and also suggested to be default value by Syed=
.
> -*/
> -
> + * Set MASTER_UPDATE_MODE to 0
> + * This is needed for DRR, and also suggested to be default value by Sye=
d.
> + */
>         uint32_t value;
>
>         value =3D 0;
> @@ -209,9 +208,9 @@ static void dce110_timing_generator_v_wait_for_vblank=
(struct timing_generator *t
>         }
>  }
>
> -/**
> -* Wait till we are in VActive (anywhere in VActive)
> -*/
> +/*
> + * Wait till we are in VActive (anywhere in VActive)
> + */
>  static void dce110_timing_generator_v_wait_for_vactive(struct timing_gen=
erator *tg)
>  {
>         while (dce110_timing_generator_v_is_in_vertical_blank(tg)) {
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel