Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210111191926.3688443-1-lee.jones@linaro.org> <20210111191926.3688443-22-lee.jones@linaro.org>
In-Reply-To: <20210111191926.3688443-22-lee.jones@linaro.org>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Tue, 12 Jan 2021 17:20:02 -0500
Message-ID: <CADnq5_Oc0ftYKMCaWz5Sa8dAsJoGPWWAj-pBXxFqrBNZDNxLFQ@mail.gmail.com>
Subject: Re: [PATCH 21/40] drm/amd/display/dc/dce110/dce110_compressor: Remove
 unused function 'dce110_get_required_compressed_surfacesize
To:     Lee Jones <lee.jones@linaro.org>
Cc:     Leo Li <sunpeng.li@amd.com>, LKML <linux-kernel@vger.kernel.org>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        David Airlie <airlied@linux.ie>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Jan 11, 2021 at 2:20 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> Fixes the following W=3D1 kernel build warning(s):
>
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_compressor.c:415:=
6: warning: no previous prototype for =E2=80=98dce110_get_required_compress=
ed_surfacesize=E2=80=99 [-Wmissing-prototypes]
>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian K=C3=B6nig" <christian.koenig@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Applied.  Thanks!

Alex

> ---
>  .../amd/display/dc/dce110/dce110_compressor.c | 30 -------------------
>  1 file changed, 30 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_compressor.c b/=
drivers/gpu/drm/amd/display/dc/dce110/dce110_compressor.c
> index 72b580a4eb856..18b0a69b0b1e8 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_compressor.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_compressor.c
> @@ -412,36 +412,6 @@ void dce110_compressor_destroy(struct compressor **c=
ompressor)
>         *compressor =3D NULL;
>  }
>
> -bool dce110_get_required_compressed_surfacesize(struct fbc_input_info fb=
c_input_info,
> -                                               struct fbc_requested_comp=
ressed_size size)
> -{
> -       bool result =3D false;
> -
> -       unsigned int max_x =3D FBC_MAX_X, max_y =3D FBC_MAX_Y;
> -
> -       get_max_support_fbc_buffersize(&max_x, &max_y);
> -
> -       if (fbc_input_info.dynamic_fbc_buffer_alloc =3D=3D 0) {
> -               /*
> -                * For DCE11 here use Max HW supported size:  HW Support =
up to 3840x2400 resolution
> -                * or 18000 chunks.
> -                */
> -               size.preferred_size =3D size.min_size =3D align_to_chunks=
_number_per_line(max_x) * max_y * 4;  /* (For FBC when LPT not supported). =
*/
> -               size.preferred_size_alignment =3D size.min_size_alignment=
 =3D 0x100;       /* For FBC when LPT not supported */
> -               size.bits.preferred_must_be_framebuffer_pool =3D 1;
> -               size.bits.min_must_be_framebuffer_pool =3D 1;
> -
> -               result =3D true;
> -       }
> -       /*
> -        * Maybe to add registry key support with optional size here to o=
verride above
> -        * for debugging purposes
> -        */
> -
> -       return result;
> -}
> -
> -
>  void get_max_support_fbc_buffersize(unsigned int *max_x, unsigned int *m=
ax_y)
>  {
>         *max_x =3D FBC_MAX_X;
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel