Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp117713pxb; Tue, 12 Jan 2021 22:11:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJx9tXUASCj2oitmUoqXLadNM02+cInCPTJ0BN4cnVHSocwZoZM+Aol7iANOos/UKKybl3mu X-Received: by 2002:a17:906:3a0d:: with SMTP id z13mr427103eje.2.1610518262142; Tue, 12 Jan 2021 22:11:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610518262; cv=none; d=google.com; s=arc-20160816; b=thh/S+lcgFXhTNMTxIJoowN6S0221e4k4IpHHoqTqzz6EAqJ7NEOIu1P8vuT5AYVwk GDDgNADGW8yMMQed0Vq9QelQ0SyfG08fzlb/+tEhwqGvNBIlKGXqsteI65V5J9btUN6/ URLsjiT3kP6XffpicN535QPsiv3tpX7crYSWBZKnm0AJR9LzCBQEURahgplau64ZUFdF IHBTQXdETtSQp/T1kGHGQxoBbiXGd4FVCNbFHrSUkqF57wReYutq8+Pg8L9m+DE8c5ZU apTavCW4jcnwrJK9+KPSeny9RI3eM5LhxwZ7kA+waLULjdwtHlXWh54OSo/YeHiYnfiO n9QA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=bzQFE72I/JmdqPXm3sPTdt50Ied3UyCVZBo3EP9qpfA=; b=pEFd6y2wTEyu4l3wRJQRmpz5Mvrrld1o4JwwMF4EZ7dMJwQaajP6nxCEa64rEW81IF sbG/tQd/KXM0IJxLTeTdQduw+L467f8UnoA2cGrhaxcMUYK1uF7cl+4vwLGekYxnerdV g8/7mj7U+xCJFZpf1R5OF75woLNwRmlhjTfiv3xRWLrcat9IECF8tiRRhrwuMcgTDl2M dKJS7K58vMhnoUWzbUURX8V1H8/v20/NfGJ3+VnFX1AM5ZkXS9Eu1uPfZOWvKYaln//J 6HV2J4oLHChdVYoVzqc79WQvMNnjbONO0e1tXI/6dlDSC6bQwnVb1GFuwbP4KC99s3d+ pFUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=ZUtRg0A9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id si7si470498ejb.5.2021.01.12.22.10.39; Tue, 12 Jan 2021 22:11:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=ZUtRg0A9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726642AbhAMGIS (ORCPT + 99 others); Wed, 13 Jan 2021 01:08:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725910AbhAMGIR (ORCPT ); Wed, 13 Jan 2021 01:08:17 -0500 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F36BC061575 for ; Tue, 12 Jan 2021 22:07:37 -0800 (PST) Received: by mail-pl1-x633.google.com with SMTP id j1so485361pld.3 for ; Tue, 12 Jan 2021 22:07:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=bzQFE72I/JmdqPXm3sPTdt50Ied3UyCVZBo3EP9qpfA=; b=ZUtRg0A9O8s+bnqw0Z0boHhOu5ZFztEcCyW2vzpZb//xumrTqsqWGdLgzXO2RUL5D0 jspQOLHArKkE935wTfyOxk67UvxMWhy39dnjrc/D5vmeZ+VXpg6cJx1j8UHTpuQxfkg5 A3/6oiSUjlKmYmSiGwI1yUQtpxEYajq5rRM4w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=bzQFE72I/JmdqPXm3sPTdt50Ied3UyCVZBo3EP9qpfA=; b=s38qrSD02yDHzWi0vWhWt4idbhxul94iY2Hh+YfYiM/ViDErrI2EWAeii10LaIxzO/ SDDZ3/aa04/yZkjJQnxiP+lLSVrOmIY/S4z5DRbmUIo09RWfbayhirAA4mqaJVPN6K1m INHQMh+1MNU3Ld40Du0zyOKYiOmG8vjCy7UDfNoJvpwzR9VNeNPO8j2qsSN7JGpJaxQy /NyyCr1TO/DXTZ2kecCaNkvg/DyJ1e7jma6Ta08nq0Q+JdL9QMsAU/xNAuZrlWmZPrRM kBwLn1TnzqbcoMxeZGTJhUCzHwhy7UyAxjQb+26UbPHapGfZC09m+Xa2HTyGur6A00XQ 5LwQ== X-Gm-Message-State: AOAM530fs4YOVrpZUx3xSwRltH4VWCkv2ogqb0SPLtViVzBuemFp9yXg 01vHZuKi5c6Er2j9uFIalcW3XQ== X-Received: by 2002:a17:90b:350b:: with SMTP id ls11mr558246pjb.166.1610518056830; Tue, 12 Jan 2021 22:07:36 -0800 (PST) Received: from drinkcat2.tpe.corp.google.com ([2401:fa00:1:b:7220:84ff:fe09:41dc]) by smtp.gmail.com with ESMTPSA id y21sm1263556pfr.90.2021.01.12.22.07.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jan 2021 22:07:35 -0800 (PST) From: Nicolas Boichat To: Rob Herring , Steven Price , Alyssa Rosenzweig Cc: Tomeu Vizoso , fshao@chromium.org, boris.brezillon@collabora.com, hsinyi@chromium.org, hoegsberg@chromium.org, Nicolas Boichat , Daniel Vetter , David Airlie , Matthias Brugger , Rob Herring , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: [PATCH v10 0/4] drm/panfrost: Add support for mt8183 GPU Date: Wed, 13 Jan 2021 14:06:59 +0800 Message-Id: <20210113060703.3122661-1-drinkcat@chromium.org> X-Mailer: git-send-email 2.30.0.284.gd98b1dd5eaa7-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! Follow-up on the v5 [1], things have gotten significantly better in the last 9 months, thanks to the efforts on Bifrost support by the Collabora team (and probably others I'm not aware of). I've been testing this series on a MT8183/kukui device, with a chromeos-5.10 kernel [2], and got basic Chromium OS UI up with mesa 20.3.2 (lots of artifacts though). devfreq is currently not supported, as we'll need: - Clock core support for switching the GPU core clock (see 2/4). - Platform-specific handling of the 2-regulator (see 3/4). Since the latter is easy to detect, patch 3/4 just disables devfreq if the more than one regulator is specified in the compatible matching table. [1] https://patchwork.kernel.org/project/linux-mediatek/cover/20200306041345.259332-1-drinkcat@chromium.org/ [2] https://crrev.com/c/2608070 Changes in v10: - Fix the binding to make sure sram-supply property can be provided. Changes in v9: - Explain why devfreq needs to be disabled for GPUs with >1 regulators. Changes in v8: - Use DRM_DEV_INFO instead of ERROR Changes in v7: - Fix GPU ID in commit message - Fix GPU ID in commit message Changes in v6: - Rebased, actually tested with recent mesa driver. Nicolas Boichat (4): dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183 arm64: dts: mt8183: Add node for the Mali GPU drm/panfrost: devfreq: Disable devfreq when num_supplies > 1 drm/panfrost: Add mt8183-mali compatible string .../bindings/gpu/arm,mali-bifrost.yaml | 28 +++++ arch/arm64/boot/dts/mediatek/mt8183-evb.dts | 6 + .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 6 + arch/arm64/boot/dts/mediatek/mt8183.dtsi | 105 ++++++++++++++++++ drivers/gpu/drm/panfrost/panfrost_devfreq.c | 9 ++ drivers/gpu/drm/panfrost/panfrost_drv.c | 10 ++ 6 files changed, 164 insertions(+) -- 2.30.0.284.gd98b1dd5eaa7-goog