Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210107052206.2599844-1-hsinyi@chromium.org> <20210107052206.2599844-2-hsinyi@chromium.org>
 <20210113032031.GA1460993@robh.at.kernel.org>
In-Reply-To: <20210113032031.GA1460993@robh.at.kernel.org>
From:   Hsin-Yi Wang <hsinyi@chromium.org>
Date:   Wed, 13 Jan 2021 14:23:59 +0800
Message-ID: <CAJMQK-hCm05S6QCWz6i-vuJKj8GKcaQFYPBYYAd4B8NBL8q5Yw@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] arm64: dts: mt8183: Add krane-sku0 board.
To:     Rob Herring <robh@kernel.org>
Cc:     "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        Nicolas Boichat <drinkcat@chromium.org>,
        Devicetree List <devicetree@vger.kernel.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>,
        lkml <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Jan 13, 2021 at 11:20 AM Rob Herring <robh@kernel.org> wrote:
>
> On Thu, Jan 07, 2021 at 01:22:06PM +0800, Hsin-Yi Wang wrote:
> > Similar to krane-sku176 but using a different panel source.
> >
> > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> > ---
> > Change:
> > v2: move compatible to board dts
> > ---
> >  .../devicetree/bindings/arm/mediatek.yaml     |  1 +
> >  arch/arm64/boot/dts/mediatek/Makefile         |  1 +
> >  .../dts/mediatek/mt8183-kukui-krane-sku0.dts  | 23 +++++++++++++++++++
> >  3 files changed, 25 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts
> >
> > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> > index 53f0d4e3ea982..3276f7a2ce672 100644
> > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> > @@ -120,6 +120,7 @@ properties:
> >            - const: mediatek,mt8183
> >        - description: Google Krane (Lenovo IdeaPad Duet, 10e,...)
> >          items:
> > +          - const: google,krane-sku0
> >            - const: google,krane-sku176
> >            - const: google,krane
> >            - const: mediatek,mt8183
>
> This says you must have all 4 compatible strings in the order listed.
> That doesn't match your dts. I assume you want the first 2 under an
> 'enum' so there's 3 strings with the first one being sku0 or sku176?
>
Right. I'll fix in the next version. Thanks
> Rob