Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210107085942.2891525-1-yuhsuan@chromium.org>
 <20210107085942.2891525-2-yuhsuan@chromium.org> <e6c33a5f-1765-7cb6-8479-ff049992f2b7@collabora.com>
In-Reply-To: <e6c33a5f-1765-7cb6-8479-ff049992f2b7@collabora.com>
From:   Yu-Hsuan Hsu <yuhsuan@chromium.org>
Date:   Wed, 13 Jan 2021 14:58:41 +0800
Message-ID: <CAGvk5Ppm_+twECMf2x6P4U24vkcwn7WPOCZtnjwNHG=CtmOenA@mail.gmail.com>
Subject: Re: [PATCH 2/2] ASoC: cros_ec_codec: Reset I2S RX when probing
To:     Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        ALSA development <alsa-devel@alsa-project.org>,
        "Gustavo A . R . Silva" <gustavoars@kernel.org>,
        Takashi Iwai <tiwai@suse.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Guenter Roeck <groeck@chromium.org>,
        Mark Brown <broonie@kernel.org>,
        Prashant Malani <pmalani@chromium.org>,
        Pi-Hsun Shih <pihsun@chromium.org>,
        Benson Leung <bleung@chromium.org>,
        Cheng-Yi Chiang <cychiang@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Enric Balletbo i Serra <enric.balletbo@collabora.com> =E6=96=BC 2021=E5=B9=
=B41=E6=9C=8813=E6=97=A5 =E9=80=B1=E4=B8=89 =E4=B8=8A=E5=8D=8812:34=E5=AF=
=AB=E9=81=93=EF=BC=9A
>
> Hi Yu-Hsuan,
>
> Thank you for the patch.
>
> On 7/1/21 9:59, Yu-Hsuan Hsu wrote:
> > It is not guaranteed that I2S RX is disabled when the kernel booting.
> > For example, if the kernel crashes while it is enabled, it will keep
> > enabled until the next time EC reboots. Reset I2S RX when probing to
> > fix this issue.
> >
> > Signed-off-by: Yu-Hsuan Hsu <yuhsuan@chromium.org>
>
> If I am not mistaken this is the four version of this patchset (see [1]).=
 Please
> prefix your patches with the proper version and maintain a changelog for =
them,
> otherwise makes difficult to follow all the discussions already done.
>
> [1]
> v1: https://lkml.org/lkml/2020/7/8/173
> v2: https://mailman.alsa-project.org/pipermail/alsa-devel/2020-July/17093=
3.html
> v3:
> https://patchwork.kernel.org/project/alsa-devel/patch/20210106050559.1459=
027-1-yuhsuan@chromium.org/
> v4: https://patchwork.kernel.org/project/alsa-devel/list/?series=3D410441
Sorry that I forgot to add version. Will add v5 in the next patch. Thanks!
>
> > ---
> >  sound/soc/codecs/cros_ec_codec.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/sound/soc/codecs/cros_ec_codec.c b/sound/soc/codecs/cros_e=
c_codec.c
> > index f33a2a9654e7..28b3e2c48c86 100644
> > --- a/sound/soc/codecs/cros_ec_codec.c
> > +++ b/sound/soc/codecs/cros_ec_codec.c
> > @@ -1011,6 +1011,13 @@ static int cros_ec_codec_platform_probe(struct p=
latform_device *pdev)
> >       }
> >       priv->ec_capabilities =3D r.capabilities;
> >
> > +     /* Reset EC codec i2s rx. */
> > +     p.cmd =3D EC_CODEC_I2S_RX_RESET;
> > +     ret =3D send_ec_host_command(priv->ec_device, EC_CMD_EC_CODEC_I2S=
_RX,
> > +                                (uint8_t *)&p, sizeof(p), NULL, 0);
> > +     if (ret)
> > +             dev_warn(dev, "failed to EC_CODEC_I2S_RESET: %d\n", ret);
> > +
>
> My comment in the first version is still valid, I guess. This command was
> introduced later and with an old firmware I suspect this message will app=
ear on
> every boot, right? So, to solve the issue and get rid of this warn you're=
 forced
> to upgrade the firmware. Would make sense to handle returned error value =
to warn
> when the firmware needs to be updated and error and break when is really =
an error?
>
> We have mapped ec error codes to linux error codes. So, it should be poss=
ible now.
Oh, I didn't notice it. Thanks for the remind. I will work on it.
>
> Thanks,
>  Enric
>
> >       platform_set_drvdata(pdev, priv);
> >
> >       ret =3D devm_snd_soc_register_component(dev, &i2s_rx_component_dr=
iver,
> >