Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp253137pxb; Wed, 13 Jan 2021 02:48:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJwQMJMkeeQTUDoGdX4SbM95YU9kwRjm3JI6YNWuTMVyuKue0FuHumsi/VeWLsVifpwquIdo X-Received: by 2002:a17:906:6608:: with SMTP id b8mr1112241ejp.71.1610534887406; Wed, 13 Jan 2021 02:48:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610534887; cv=none; d=google.com; s=arc-20160816; b=kByYG+y3D11qd76gZXFH98eGgn3Iw2H3dBRqcHPyxBTJIykc2CWyyXALjk6Uk4eLYq ZCoUuc/fHHat+EbiCnBI+CzUkpIjBTyu187EqUseZL5cx+jsxnmS0MTSXJ45CpJYd373 fvu0EiDPOlSGO62RD05j+//NwPjaS4YYXcndUQjPv2r2wc428NOrxmC+MaJedyqn5gB+ g+bGX51Gj5yxqGxQICpxPEmGFTjwnwwkKyT6ufIV4nMLcsOheF3bP7NWJe/XwckAXfCH sjDcuMepitTQr/VQ4ySwhg6guva3iMjPKl/yO4S0obhaHobQXQEmV54VV1EzVGnt6dQT XX8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=iu+C+8D5LwT7HSkoHTJqSby6I4aAJregUM9ez5Yf5UI=; b=yE7ytgN/h/MnnCPcx5j8M6CfIaDdVc5bNOWUhUKIyT/fi/9LxNsQk2keBDsft/w2er W83VmoOujn4i067B+rfHpCd1x5qW9IVIzi2Jgs3jhVxXTQ7Q4nDMeGi7wE+JuBcfCYYJ C1/VhEQA3wnziX9JZn+0eNH1o3aheVJT2i67aX+1eHIk+MR/vxjW3P5xg7n41QLI50di jyO2yjMnZYwMGWYfpGZKfos5QhzEV/RFqKDPxDyYdx5GjZ2BU4wHkxwUdA1TixKmwexJ C9TWoMqm7BqYeeypchpu2vhGreX0vPSjgT+Qe4a36hg18R9DczQuXs7DpCYNEZj0o/3o Dqhg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gj13si698746ejb.521.2021.01.13.02.47.43; Wed, 13 Jan 2021 02:48:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727630AbhAMKor (ORCPT + 99 others); Wed, 13 Jan 2021 05:44:47 -0500 Received: from elvis.franken.de ([193.175.24.41]:47759 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727304AbhAMKoq (ORCPT ); Wed, 13 Jan 2021 05:44:46 -0500 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1kzddE-00021m-05; Wed, 13 Jan 2021 11:44:04 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 2B1E5C02B1; Wed, 13 Jan 2021 11:40:57 +0100 (CET) Date: Wed, 13 Jan 2021 11:40:57 +0100 From: Thomas Bogendoerfer To: Martin Blumenstingl Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, john@phrozen.org, hauke@hauke-m.de Subject: Re: [PATCH] MIPS: lantiq: irq: register the interrupt controllers with irqchip_init Message-ID: <20210113104057.GF10351@alpha.franken.de> References: <20210109195351.2724769-1-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210109195351.2724769-1-martin.blumenstingl@googlemail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 09, 2021 at 08:53:51PM +0100, Martin Blumenstingl wrote: > Add support for more interrupt controllers by switching from > of_irq_init() to irqchip_init() in Lantiq's arch_init_irq(). This > requires switching the ICU interrupt controller to use > IRQCHIP_DECLARE(), like a real irqchip driver would do. > > This is needed for future changes when new irqchip drivers are > implemented: > - a dedicated driver for the EIU interrupt controller > - a driver for the MSI PIC (Programmable Interrupt Controller) found on > VRX200 and newer SoCs > - ..or any other driver which uses IRQCHIP_DECLARE > > Signed-off-by: Martin Blumenstingl > --- > arch/mips/lantiq/irq.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]