Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: i4yMyrfLqYNeTywb5IobYinT4X/oDmP08dLmYQeiH7A2cuDITJ7PK0TX0sWhgFuzXiH3un3rx+
 9zqsU1dUMx6Q==
IronPort-SDR: GmAM/i5R61hb8NxYgDEqZuOpRnjbczA38Z9k1eNZ4tN9qowY61kjGRBYoTSpoqEQjeuBMucovY
 JELjplp0AUJQ==
Subject: Re: [PATCH v2 2/6] perf evsel: Introduce an observed performance
 device
To:     Namhyung Kim <namhyung@kernel.org>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Jiri Olsa <jolsa@redhat.com>, Andi Kleen <ak@linux.intel.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Rogers <irogers@google.com>,
        Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>
References: <20201223130320.3930-1-alexander.antonov@linux.intel.com>
 <20201223130320.3930-3-alexander.antonov@linux.intel.com>
 <CAM9d7cikD68d0iAiFQ2A6J5tDqM-jphqQUjLAV0vQZqH7Mi37A@mail.gmail.com>
From:   Alexander Antonov <alexander.antonov@linux.intel.com>
Message-ID: <1c42b0c5-2731-ff9c-0b8b-4becf8ecef07@linux.intel.com>
Date:   Wed, 13 Jan 2021 14:13:44 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <CAM9d7cikD68d0iAiFQ2A6J5tDqM-jphqQUjLAV0vQZqH7Mi37A@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk


On 1/6/2021 11:44 AM, Namhyung Kim wrote:
> Hi,
>
> On Wed, Dec 23, 2020 at 10:03 PM Alexander Antonov
> <alexander.antonov@linux.intel.com> wrote:
>> Adding evsel::perf_device void pointer.
>>
>> For performance monitoring purposes, an evsel can have a related device.
>> These changes allow to attribute, for example, I/O performance metrics
>> to IIO stack.
>>
>> Signed-off-by: Alexander Antonov <alexander.antonov@linux.intel.com>
>> ---
>>   tools/perf/util/evsel.h | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h
>> index 79a860d8e3ee..c346920f477a 100644
>> --- a/tools/perf/util/evsel.h
>> +++ b/tools/perf/util/evsel.h
>> @@ -127,6 +127,7 @@ struct evsel {
>>           * See also evsel__has_callchain().
>>           */
>>          __u64                   synth_sample_type;
>> +       void                    *perf_device;
> Maybe we can use the existing 'priv' field.
>
> Thanks,
> Namhyung

Hello Namhyung,

Looks like the 'priv' field isn't used in this case. I suppose it can be
re-used in iiostat mode.

Thanks,
Alexander
>
>>   };
>>
>>   struct perf_missing_features {
>> --
>> 2.19.1
>>