Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp291169pxb; Wed, 13 Jan 2021 03:53:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJySZmOtVRoCwSvBuz/FbXiUmCcv9i6g2Vpjfn1QTUHHZwlffBecawxnTBEIddXzLFILtKxC X-Received: by 2002:a17:907:4126:: with SMTP id mx6mr1263630ejb.91.1610538795331; Wed, 13 Jan 2021 03:53:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610538795; cv=none; d=google.com; s=arc-20160816; b=QUfujAYNUM8eZhwss3xtonFqANM9vM4spt5t3Tw8g+UXiaIBqa8WD+DJajTXL4MxBn RmOVARHovol99y2/3GYDcvutInzghUWptKRl6QPydBC0MnHw/N3UK07c9Qe6bF7JzbAG GswhUh4a2jPPVtTeI3gSEIBl9S/DvLTnLjTxIk+yWGHuY39PrVXEdVamjIDLCqUNiEr0 iEbahvSMPcZF0C6RrkWOvZ481flYC3wPF92SlZmSM2VQMsG1FEooGWVOt3DsZMMBXEUB 9JLVs2Y0dCsHH6u8kSGIDMEasmPYPZxqAdU+t8lnfeEUCGDy4Dvbxmlyi1mGwdnR/gfB b4XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=LI6ClrAOVtXqhMOuCKVaSquOPgOyqemFL3U8OGABNws=; b=j1v2KV4efMbyd6Z14cZ0+Skevgs8/p+3S25oKMl4n+YkNPwFW6rJyIQiNtCwI4DEsw B4GrzgIwPPgTadyP7nOtgfb73N3CydBxF800WxCJqbenC88f9R2+iQccZx4uVvZZ3rmi 7DgaEYlAsZpT3n0IFFAWbTvxCx1Uk6gM57gqTKdO5ZzoySapqXaly65EXkRr0Rmol1fN xm1qHi5nsc7gXCRpcvv2H61LX7BUZyPVabXDFIYm7lWaoCdj8Vrj8vYgeLlJf5sbjNpB w0iRFmJfi/rv1U3zAUMh65YXvMBPhrri53G/CdZWOtWfnAuZPMPumTlKNSlhip0hM8g7 CZRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mfDZ21d1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d21si747598eja.412.2021.01.13.03.52.51; Wed, 13 Jan 2021 03:53:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mfDZ21d1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726754AbhAMLuc (ORCPT + 99 others); Wed, 13 Jan 2021 06:50:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:50832 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725924AbhAMLub (ORCPT ); Wed, 13 Jan 2021 06:50:31 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 67DB5233ED; Wed, 13 Jan 2021 11:49:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610538591; bh=+S0tzqjMh0ZwiuGG6yUIeAgxYJd7e/XUIrh4pdYISfU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mfDZ21d1SRBkJt5eo3mICWuARqMGAJPu0FLRUvtRdqyBymBOcD4iXxP5A46Z9COYK da2HAsXcGvLSTvWRqAV4Psr3thuSMStDm0UE8mwC5qzK4aL+3x2CU/ipSE8LyTslvB Wtye7VubiqwzirkwzUX+71QdzoR4MdbdT/YRrexTvPSwJagSjMkbz/Rtpjmbwq/bLU MHGySri9V2xoHrwItMpwkkFb4wYo/j9FcH+LcXwf15FPS8BL79ejCPkAwPZ+2/4OGi 6FNhI8Tm9IXud8G0CE+XN5MSC32SMsiXpaUZk9uJgu+qU3UT09lTftDcJGQI2iIHcE HRxKIH5qckVMg== Date: Wed, 13 Jan 2021 17:19:41 +0530 From: Vinod Koul To: Liam Beguin Cc: geert@linux-m68k.org, kishon@ti.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/1] phy: tusb1210: use bitmasks to set VENDOR_SPECIFIC2 Message-ID: <20210113114941.GD2771@vkoul-mobl> References: <20201211191241.21306-1-liambeguin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201211191241.21306-1-liambeguin@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11-12-20, 14:12, Liam Beguin wrote: > From: Liam Beguin > > Start by reading the content of the VENDOR_SPECIFIC2 register and update > each bit field based on device properties when defined. > > The use of bit masks prevents fields from overriding each other and > enables users to clear bits which are set by default, like datapolarity > in this instance. Applied, thanks -- ~Vinod